Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-dir and logtostderr are still referenced in the kubelet 1.26 docs although they were removed #38599

Closed
jsturtevant opened this issue Dec 22, 2022 · 2 comments · Fixed by #38612
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jsturtevant
Copy link
Contributor

This is a Bug Report

Problem:

The doc https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/ shows documentation for log-dir and logtostderr:

--log-dir string
If non-empty, write log files in this directory. (DEPRECATED: will be removed in a future release, see [here](https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components).)

but they were removed from kubelet in 1.26:

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.26.md): Legacy klog flags are no longer available. Only -v and -vmodule are still supported. (https://github.com/kubernetes/kubernetes/pull/112120, [@pohly](https://github.com/pohly)) [SIG Architecture, CLI, Instrumentation, Node and Testing]. The PR linked is merged in v1.26: kubernetes/kubernetes#112120

Found in kubernetes-sigs/sig-windows-tools#259 (comment)

@jsturtevant jsturtevant added the kind/bug Categorizes issue or PR as related to a bug. label Dec 22, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 22, 2022
@sftim
Copy link
Contributor

sftim commented Dec 22, 2022

I have a feeling that https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/ needs a special process to update it after a release - maybe we didn't yet do that.

/sig release
/language en
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 22, 2022
@tengqm
Copy link
Contributor

tengqm commented Dec 23, 2022

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants