Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubelet reference for 1.26 #38612

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Update kubelet reference for 1.26 #38612

merged 1 commit into from
Feb 3, 2023

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Dec 23, 2022

This PR updates the reference for the kubelet command line options. These options are manually maintained by cross checking the output from kubelet --help, because we are unable to generate it from the source code.

closes: #38599

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 23, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 23, 2022
@netlify
Copy link

netlify bot commented Dec 23, 2022 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit e582b3d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63b2d3dd131a0100081468e2
😎 Deploy Preview https://deploy-preview-38612--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mengjiao-liu
Copy link
Member

Preview page: https://deploy-preview-38612--kubernetes-io-main-staging.netlify.app/docs/reference/command-line-tools-reference/kubelet/

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ecad3d98b57ddaae30ef081b2f4bd3e4884b4838

Pradumnasaraf
Pradumnasaraf approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tengqm
Update kubelet reference for 1.26
e582b3d 
This PR updates the reference for the kubelet command line options.
These options are manually maintained by cross checking the output from
`kubelet --help`, because we are unable to generate it from the source
code.
@tengqm
Copy link
Contributor Author

tengqm commented Jan 2, 2023

Comments addressed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
Pradumnasaraf
Pradumnasaraf approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 40dfb814b34cac3858cc470e533ab201ded12046

divya-mohan0209
divya-mohan0209 reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good.
However, there are two ways we have used to flag Alpha features? Is that expected. For example, Line 664 and Line 769. One has a warning and one is Alpha in between parentheses?

@tengqm
Copy link
Contributor Author

tengqm commented Jan 6, 2023

This overall looks good. However, there are two ways we have used to flag Alpha features? Is that expected. For example, Line 664 and Line 769. One has a warning and one is Alpha in between parentheses?

Those are how the upstream comment are written.

@reylejano
Copy link
Member

Changes to the kubelet reference docs would need to be made in the kubelet code comments and regenerate the kubelet reference docs
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Pradumnasaraf, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1be60ad into kubernetes:main Feb 3, 2023
@tengqm tengqm deleted the update-kubelet-ref branch June 5, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 requested changes

@Pradumnasaraf Pradumnasaraf Pradumnasaraf approved these changes

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

Assignees

@mengjiao-liu mengjiao-liu

@Pradumnasaraf Pradumnasaraf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log-dir and logtostderr are still referenced in the kubelet 1.26 docs although they were removed
6 participants
@tengqm @mengjiao-liu @k8s-ci-robot @reylejano @divya-mohan0209 @Pradumnasaraf