Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added patch verb for volumesnapshotcontents resource to vsphere-csi-controller-role for the compatibility with external-snapshotter 5.0 #1446

Conversation

lintongj
Copy link
Contributor

What this PR does / why we need it:
Based on kubernetes-csi/external-snapshotter#526, the RABC rules for csi-snapshotter needs to be updated if vSphere CSI driver uses external-snapshotter 5.0 onward. So, we need to make this manifest update.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

N/A

Testing done:

  • Manual testing: Dynamically provision a RWO volume and provision a snapshot of the volume. Both of them works fine.

Special notes for your reviewer:

N/A

Release note:

Added patch verb for volumesnapshotcontents resource to vsphere-csi-controller-role for the compatibility with external-snapshotter 5.0

…ontroller-role for the compatibility with external-snapshotter 5.0
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lintongj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2021
@lintongj
Copy link
Contributor Author

/assign @xing-yang

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 825

@lintongj
Copy link
Contributor Author

/assign @deepakkinni

@k8s-ci-robot
Copy link
Contributor

@lintongj: GitHub didn't allow me to assign the following users: deepakkinni.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @deepakkinni

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor

So this is for the CSI snapshotter sidecar. What about rbac for snapshot-controller? Do we just directly use the ones in external-snapshotter repo?

@svcbot-qecnsdp
Copy link

Block vanilla build status: FAILURE 
Stage before exit: testbed-deployment 

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 826

@svcbot-qecnsdp
Copy link

Block vanilla build status: FAILURE 
Stage before exit: testbed-deployment 

@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 16, 2021
@lintongj
Copy link
Contributor Author

So this is for the CSI snapshotter sidecar. What about rbac for snapshot-controller? Do we just directly use the ones in external-snapshotter repo?

That’s correct. This RBAC for csi snapshotter sidecar only. We always get rbac for snapshot-controller from upstream external-snapshotter repo

@xing-yang
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@deepakkinni
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakkinni, lintongj, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deepakkinni,xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3bb0a80 into kubernetes-sigs:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants