-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added patch verb for volumesnapshotcontents resource to vsphere-csi-controller-role for the compatibility with external-snapshotter 5.0 #1446
Conversation
…ontroller-role for the compatibility with external-snapshotter 5.0
Hi @lintongj. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @xing-yang |
Started vanilla Block pipeline... Build Number: 825 |
/assign @deepakkinni |
@lintongj: GitHub didn't allow me to assign the following users: deepakkinni. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
So this is for the CSI snapshotter sidecar. What about rbac for snapshot-controller? Do we just directly use the ones in external-snapshotter repo? |
|
Started vanilla Block pipeline... Build Number: 826 |
|
/ok-to-test |
That’s correct. This RBAC for csi snapshotter sidecar only. We always get rbac for snapshot-controller from upstream external-snapshotter repo |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakkinni, lintongj, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Based on kubernetes-csi/external-snapshotter#526, the RABC rules for csi-snapshotter needs to be updated if vSphere CSI driver uses external-snapshotter 5.0 onward. So, we need to make this manifest update.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #N/A
Testing done:
Special notes for your reviewer:
N/A
Release note: