-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JSON patch for many VolumeSnapshot and VolumeSnapshotContent updates #526
Use JSON patch for many VolumeSnapshot and VolumeSnapshotContent updates #526
Conversation
/hold |
50 error occurrences with MergePatchType as expected with ccfe3c7
Trying with JSONPatch now as suggested. |
JSONPatch seems to bring this count down for the one area I added it (updateContentErrorStatusWithEvent)
|
ab6307e
to
a635fdc
Compare
abd5ce6
to
ab4503b
Compare
ab4503b
to
e6e14c1
Compare
85a2612
to
294be83
Compare
@xing-yang the latest PR tests have zero occurrences of the Thanks @bswartz for the JSON patch suggestion! |
/assign @xing-yang |
Thanks @ggriffiths! This is great progress! |
- Also address PR feedback re: avoid a deepCopy for annotations patch Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
Will squash these commits once an initial LGTM is given. Smallers commits have been useful while testing whether or not individual patch additions break the build. |
@ggriffiths: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3249699
to
0c60d1e
Compare
Ready for re-review @xing-yang |
Signed-off-by: Grant Griffiths <ggriffiths@purestorage.com>
0c60d1e
to
ad7dfe6
Compare
Good job @ggriffiths! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggriffiths, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The operand now requires permissions to patch VolumeSnapshot + VolumeSnapshotContent (+ their statuses). See kubernetes-csi/external-snapshotter#526
Signed-off-by: Grant Griffiths ggriffiths@purestorage.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR addresses the "object has been modified" issue we see a lot in the snapshot-controller/snapshotter.
Before this PR, we were seeing ~30-50 occurrences of this error in the snapshot-controller/snapshotter logs.
This PR only addresses the problematic areas found in the e2e PR tests. If we continue to see more of these errors, we can address replace the remaining Update/UpdateStatus calls in a separate PR.
Which issue(s) this PR fixes:
Fixes #525
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?: