Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cncf job migration test #444

Merged

Conversation

ritikaguptams
Copy link
Contributor

Building on this PR: https://github.com/kubernetes-sigs/windows-testing/pull/439/files to build ability to test job migration to Azure CNCF subscription.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ritikaguptams. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2024
@upodroid
Copy link
Member

upodroid commented Jul 8, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2024
capz/run-capz-e2e.sh Outdated Show resolved Hide resolved
@jsturtevant
Copy link
Contributor

/hold
We don't want to this merge, tests can still be run with /test pull-e2e-capz-windows-2022-extension-community

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@ritikaguptams ritikaguptams force-pushed the cncf-job-migration-test branch 3 times, most recently from 8ad5ae3 to 25bd06d Compare July 8, 2024 18:18
@ritikaguptams
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-community

4 similar comments
@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-community

@ritikaguptams
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-community

@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-community

@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-community

capz/run-capz-e2e.sh Outdated Show resolved Hide resolved
capz/run-capz-e2e.sh Outdated Show resolved Hide resolved
capz/run-capz-e2e.sh Outdated Show resolved Hide resolved
@jsturtevant
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2024
@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-community

@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2024
@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-community

1 similar comment
@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-community

@jsturtevant
Copy link
Contributor

missing anonymous pull access on the acr, its been added.

/test pull-e2e-capz-windows-2022-extension-community

@jsturtevant
Copy link
Contributor

The test passed 💯 https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_windows-testing/444/pull-e2e-capz-windows-2022-extension-community/1811808608870993920

We are going to clear the resources and re-apply the terrafrom we've been building out with kubernetes/k8s.io#6925 and will re-run

# So we are using a custom repository for the test "Container Runtime blackbox test when running a container with a new image should be able to pull from private registry with secret [NodeConformance]"
# Must also set label preset-windows-private-registry-cred: "true" on the job
export KUBE_TEST_REPO_LIST="$SCRIPT_ROOT/../images/image-repo-list-private-registry"
ADDITIONAL_E2E_ARGS+=("--docker-config-file=${DOCKER_CONFIG_FILE}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be in the community sub, we will move this to a private registry in the private sub and use kubelet credential provider to access it. we need to wire this in to our templates but the credential binaries are already there kubernetes-sigs/cluster-api-provider-azure#4679 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsturtevant
Copy link
Contributor

/test ls

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: The specified target(s) for /test were not found.
The following commands are available to trigger optional jobs:

  • /test pull-e2e-capz-validate-pr-templates
  • /test pull-e2e-capz-windows-2022-extension
  • /test pull-e2e-capz-windows-2022-extension-community
  • /test pull-e2e-capz-windows-2022-extension-gmsa
  • /test pull-e2e-run-capz-sh-windows-2022-hyperv

Use /test all to run the following jobs that were automatically triggered:

  • pull-e2e-capz-windows-2022-extension

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ritikaguptams
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-community

1 similar comment
@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-community

This requires the jobs to have preset-azure-community.

co-authored-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-community

1 similar comment
@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-community

@jsturtevant
Copy link
Contributor

the extension failed a single tests which looks to have been renamed over night, its passing in nightly CI so maybe the new test is flaky? Kubernetes e2e suite: [It] [sig-windows] [Feature:Windows] SecurityContext should ignore ProcMount Specific SecurityContext if set

image

@jsturtevant
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor

The tests are failing because of kubernetes/kubernetes#126180

@jsturtevant
Copy link
Contributor

jsturtevant commented Jul 17, 2024

/assign @marosset

Even though one test is failing (kubernetes/kubernetes#126180) the cluster is coming online and tests are running. We need this for the job https://testgrid.k8s.io/sig-windows-master-release#capz-windows-2022-master which we moved to the community cluster

@marosset
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, ritikaguptams

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@ritikaguptams: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-capz-windows-2022-extension b49686a link false /test pull-e2e-capz-windows-2022-extension
pull-e2e-capz-windows-2022-extension-community b49686a link false /test pull-e2e-capz-windows-2022-extension-community

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@jsturtevant
Copy link
Contributor

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit dfbb82e into kubernetes-sigs:master Jul 17, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants