-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cncf job migration test #444
Cncf job migration test #444
Conversation
Hi @ritikaguptams. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/hold |
8ad5ae3
to
25bd06d
Compare
/test pull-e2e-capz-windows-2022-extension-community |
4 similar comments
/test pull-e2e-capz-windows-2022-extension-community |
/test pull-e2e-capz-windows-2022-extension-community |
/test pull-e2e-capz-windows-2022-extension-community |
/test pull-e2e-capz-windows-2022-extension-community |
25bd06d
to
0046af7
Compare
0046af7
to
5fe5df4
Compare
We can now create most things but need the changes in https://github.com/kubernetes-sigs/cluster-api-provider-azure/compare/main...jsturtevant:remove-az-cli-cred-checks?expand=1 which will be added too kubernetes-sigs/cluster-api-provider-azure#4939 |
/test pull-e2e-capz-windows-2022-extension-community |
/test pull-e2e-capz-windows-2022-extension-community |
1 similar comment
/test pull-e2e-capz-windows-2022-extension-community |
missing anonymous pull access on the acr, its been added. /test pull-e2e-capz-windows-2022-extension-community |
The test passed 💯 https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_windows-testing/444/pull-e2e-capz-windows-2022-extension-community/1811808608870993920 We are going to clear the resources and re-apply the terrafrom we've been building out with kubernetes/k8s.io#6925 and will re-run |
# So we are using a custom repository for the test "Container Runtime blackbox test when running a container with a new image should be able to pull from private registry with secret [NodeConformance]" | ||
# Must also set label preset-windows-private-registry-cred: "true" on the job | ||
export KUBE_TEST_REPO_LIST="$SCRIPT_ROOT/../images/image-repo-list-private-registry" | ||
ADDITIONAL_E2E_ARGS+=("--docker-config-file=${DOCKER_CONFIG_FILE}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not be in the community sub, we will move this to a private registry in the private sub and use kubelet credential provider to access it. we need to wire this in to our templates but the credential binaries are already there kubernetes-sigs/cluster-api-provider-azure#4679 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test ls |
@jsturtevant: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-e2e-capz-windows-2022-extension-community |
1 similar comment
/test pull-e2e-capz-windows-2022-extension-community |
9850cd5
to
d78dca1
Compare
This requires the jobs to have preset-azure-community. co-authored-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com> Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
d78dca1
to
b49686a
Compare
/test pull-e2e-capz-windows-2022-extension-community |
1 similar comment
/test pull-e2e-capz-windows-2022-extension-community |
/test pull-e2e-capz-windows-2022-extension |
The tests are failing because of kubernetes/kubernetes#126180 |
/assign @marosset Even though one test is failing (kubernetes/kubernetes#126180) the cluster is coming online and tests are running. We need this for the job https://testgrid.k8s.io/sig-windows-master-release#capz-windows-2022-master which we moved to the community cluster |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, ritikaguptams The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ritikaguptams: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold cancel |
Building on this PR: https://github.com/kubernetes-sigs/windows-testing/pull/439/files to build ability to test job migration to Azure CNCF subscription.