-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial terraform scripts for azure cncf subscription #6925
base: main
Are you sure you want to change the base?
Conversation
Welcome @ritikaguptams! |
Hi @ritikaguptams. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ritikaguptams The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ca647ed
to
a59a10a
Compare
/ok-to-test |
location = "eastus" | ||
name = "capz-ci" | ||
tags = { | ||
DO-NOT-DELETE = "contact capz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should update this to a sig-cluster-lifecycle-azure email (@jackfrancis do you have a email that should be used?) and add the sig-infra/sig-test email as a contact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we have an email to share, #cluster-api-provider-azure on k8s slack or the SIG mailing list are probably our best bet:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: Are we not opening the door to some kind of on-call if we put an email contact ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it would be on call, just a pointer to someone that would know what the Resource group does? We can just keep what is there now.
@ameukam this should help to get things moving with Azure |
a59a10a
to
69d1da4
Compare
69d1da4
to
52f4c6e
Compare
Signed-off-by: Ritika Gupta <ritikagupta@microsoft.com>
52f4c6e
to
179533d
Compare
Signed-off-by: ritikaguptams <ritikagupta@microsoft.com>
e5601df
to
91f1e00
Compare
Adding scripts to create resources for Azure CNCF subscription.