Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atomic scale down option for node groups #5695

Merged
merged 10 commits into from
Jun 30, 2023
Merged

Add atomic scale down option for node groups #5695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1847875
Move two util functions from actuator to delete_in_batch, where they …
kawych May 31, 2023
61b7958
Add support for atomic scale-down in node group options
kawych May 31, 2023
292a517
Extract cropNodesToBudgets function out of actuator file
kawych May 31, 2023
7e3e15b
Support atomic scale-down option for node groups
kawych May 31, 2023
1ecb843
Respond to readability-related comments from the review
kawych Jun 21, 2023
257e66c
Don't pass NodeGroup as a parameter to functions running asynchronously
kawych Jun 21, 2023
5448bd2
Add unit test for group_deletion_scheduler
kawych Jun 21, 2023
05e1fe1
Use single AtomicScaling option for scale up and scale down
kawych Jun 26, 2023
374cf61
Address next set of comments
kawych Jun 27, 2023
753b024
Bugfix for budget cropping
kawych Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cluster-autoscaler/cloudprovider/test/test_cloud_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,9 @@ func (tng *TestNodeGroup) DeleteNodes(nodes []*apiv1.Node) error {
id := tng.id
tng.targetSize -= len(nodes)
tng.Unlock()
if tng.opts != nil && tng.opts.AtomicScaling && tng.targetSize != 0 {
return fmt.Errorf("TestNodeGroup: attempted to partially scale down a node group that should be scaled down atomically")
}
for _, node := range nodes {
err := tng.cloudProvider.onScaleDown(id, node.Name)
if err != nil {
Expand Down
2 changes: 2 additions & 0 deletions cluster-autoscaler/config/autoscaling_options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ type NodeGroupAutoscalingOptions struct {
ScaleDownUnreadyTime time.Duration
// Maximum time CA waits for node to be provisioned
MaxNodeProvisionTime time.Duration
// AtomicScaling means that all nodes should be provisioned and brought down all at once instead of one-by-one
AtomicScaling bool
}

// GCEOptions contain autoscaling options specific to GCE cloud provider.
Expand Down
257 changes: 73 additions & 184 deletions cluster-autoscaler/core/scaledown/actuation/actuator.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading