azure labels to skip in nodegroupset

[gandhipr]

What type of PR is this?

feature - skip a few azure specific labels in nodegroupset

What this PR does / why we need it:

This PR add a few azure specific labels that needs to be skipped when checking for nodegroup similarity.
This change doesn't include moving azure specific lables under /azure directory - that chore will be covered in another change

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Skips Azure-specific node labels that might mistakenly categorize nodegroups as different when, in reality, they are similar.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[x13n]

Change itself LGTM, though WDYT about moving this code to cluster-autoscaler/cloudprovider/azure/processors? You wouldn't require global CA approval that way.

/assign

[tallaxes]

The changes themselves look good (may be a good idea to normalize capitalization of constants), but the code currently does not build, likely as a result of the package move; additional post-move work needed.

[tallaxes]

/approve cancel

[tallaxes]

If we are keeping these outside of provider-specific space temporarily (for change sequencing reasons), and plan to move it the near future - let's add a comment to this effect in the description.

[gandhipr]

/test ls

[k8s-ci-robot]

@gandhipr: The specified target(s) for /test were not found.
The following commands are available to trigger optional jobs:

• /test pull-cluster-autoscaler-e2e-azure

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gandhipr]

/test pull-cluster-autoscaler-e2e-azure

[jackfrancis]

/lgtm

@MaciekPytel @gjtempleton @x13n would it make sense to schedule a follow-up item to move all of the cloud-provider-specific stuff in cluster-autoscaler/processors/nodegroupset/ into the provider-specific code surface area so that this maintenance can be performed without having to loop in core cluster-autoscaler approvers?

[x13n]

Yeah, that makes a lot of sense to me. There's no point having cloudprovider-specific processors in core CA dirs.

[jackfrancis]

Yeah, that makes a lot of sense to me. There's no point having cloudprovider-specific processors in core CA dirs.

Cool, once this gets and approval and merge I'll do that.

[x13n]

Sounds good, approving then!

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gandhipr, rakechill, tallaxes, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [x13n]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[comtalyst]

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

[k8s-infra-cherrypick-robot]

@comtalyst: new pull request created: #7262

In response to this:

/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[comtalyst]

/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

[k8s-infra-cherrypick-robot]

@comtalyst: new pull request created: #7263

In response to this:

/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[comtalyst]

/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

[k8s-infra-cherrypick-robot]

@comtalyst: new pull request created: #7264

In response to this:

/cherry-pick cluster-autoscaler-release-1.28
/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[comtalyst]

/cherry-pick cluster-autoscaler-release-1.27

[k8s-infra-cherrypick-robot]

@comtalyst: new pull request created: #7265

In response to this:

/cherry-pick cluster-autoscaler-release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.