-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAS: cloudprovider-specific nodegroupset #6907
base: master
Are you sure you want to change the base?
CAS: cloudprovider-specific nodegroupset #6907
Conversation
84ea188
to
85d96c0
Compare
/retest |
2 similar comments
/retest |
/retest |
/test pull-cluster-autoscaler-e2e-azure |
85d96c0
to
5f9cf96
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jack Francis <jackfrancis@gmail.com>
5f9cf96
to
172dcc5
Compare
@x13n @gjtempleton @MaciekPytel this one is ready for a final review |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR moves the cloudprovider-specific implementations of nodegroupset into cloudprovider-managed code areas so that they can be more easily maintained without involving core cluster-autoscaler maintainers.
This should not have any impact on compilation outcomes, the idea is to simply re-organize code.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: