-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Autoscaling for worker nodes with invalid ProviderID #6717
Fix Autoscaling for worker nodes with invalid ProviderID #6717
Conversation
Hi @maksim-paskal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
17105a0
to
4aa2c83
Compare
This change fixes a bug that arises when the user's cluster includes worker nodes not from Hetzner Cloud, such as a Hetzner Dedicated server or any server resource other than Hetzner. It also corrects the behavior when a server has been physically deleted from Hetzner Cloud. Signed-off-by: Maksim Paskal <paskal.maksim@gmail.com>
4aa2c83
to
228bd4e
Compare
/ok-to-test |
Can you add a changelog entry to the PR description?
Once this is merged, we should also port it all all current release branches (1.27-1.29). If you want you can do it, otherwise I will take care of it. |
add |
/approve |
Thank you very much! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, maksim-paskal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
Fixes #6716
Special notes for your reviewer:
This change fixes a bug that arises when the user's cluster includes worker nodes not from Hetzner Cloud, such as a Hetzner Dedicated server or any server resource other than Hetzner. It also corrects the behavior when a server has been physically deleted from Hetzner Cloud.
Does this PR introduce a user-facing change?