Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support running addon resizer on the control plane #6764

Merged
merged 2 commits into from
May 9, 2024
Merged

Support running addon resizer on the control plane #6764

merged 2 commits into from
May 9, 2024

Conversation

chelseychen
Copy link

@chelseychen chelseychen commented Apr 24, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is to harden security by decoupling the addon resizer from metrics server's deployment.

Which issue(s) this PR fixes:

Fixes #6762

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yes

Added support for running addon resizer on the control plane to harden security by decoupling the addon resizer from metrics server's deployment.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @chelseychen!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chelseychen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 24, 2024
@chelseychen
Copy link
Author

cc @kwiesmueller @raywainman

kwiesmueller
kwiesmueller requested changes Apr 24, 2024
View reviewed changes
addon-resizer/nanny/election.go Show resolved Hide resolved
addon-resizer/nanny/kubernetes_client.go Outdated Show resolved Hide resolved
addon-resizer/nanny/kubernetes_client.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
raywainman
raywainman reviewed Apr 29, 2024
View reviewed changes
addon-resizer/nanny/estimator.go Show resolved Hide resolved
addon-resizer/nanny/estimator.go Show resolved Hide resolved
addon-resizer/nanny/kubernetes_client.go Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
kwiesmueller
kwiesmueller requested changes Apr 29, 2024
View reviewed changes
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
@chelseychen chelseychen changed the title Support running addon resizer on GKE masters Support running addon resizer on the control plane Apr 29, 2024
@kwiesmueller
Copy link
Member

/ok-to-test
/lgtm
/hold
Waiting for @raywainman to finish his review too.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2024
@raywainman
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@raywainman: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kwiesmueller
Copy link
Member

/ok-to-test

@raywainman raywainman mentioned this pull request May 7, 2024
Closed
11 tasks
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@kwiesmueller
Copy link
Member

/ok-to-test

kwiesmueller
kwiesmueller requested changes May 8, 2024
View reviewed changes
addon-resizer/nanny/main/pod_nanny_test.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny_test.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
kwiesmueller
kwiesmueller approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@kwiesmueller kwiesmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit, otherwise lgtm.

addon-resizer/nanny/main/pod_nanny_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@kwiesmueller
Copy link
Member

As there are a lot of comment commits now maybe squashing is a good idea afterall.

@chelseychen
Copy link
Author

As there are a lot of comment commits now maybe squashing is a good idea afterall.

Done.

kwiesmueller
kwiesmueller approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@kwiesmueller kwiesmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/ok-to-test
/cancel-hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chelseychen, kwiesmueller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwiesmueller
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 22408d0 into kubernetes:addon-resizer-release-1.8 May 9, 2024
2 checks passed
@raywainman raywainman mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raywainman raywainman raywainman left review comments

@kwiesmueller kwiesmueller kwiesmueller approved these changes

@jbartosik jbartosik Awaiting requested review from jbartosik

Assignees

@kwiesmueller kwiesmueller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chelseychen @k8s-ci-robot @kwiesmueller @raywainman