-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose new /metrics endpoint to allow monitoring of addon-resizer #6916
Expose new /metrics endpoint to allow monitoring of addon-resizer #6916
Conversation
/assign chelseychen |
@raywainman: GitHub didn't allow me to assign the following users: chelseychen. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LGTM, thanks for the change! |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwiesmueller, raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-hold Resolved comments and Kevin re-LGMT'ed and approved. |
69675bd
into
kubernetes:addon-resizer-release-1.8
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds Prometheus metrics to addon-resizer, allowing monitoring of overall health. Initial implementation adds a single metric called
addon_resizer_execution_outcome
which is a simple counter metric that tracks the outcome of every addon-resizer loop (for example, whether addon-resizer actually updated the deployment for metrics-server).Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Follow up to #6764 where addon-resizer is made compatible to run in the control plane.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
To use:
expose-metrics
flag is set totrue
./metrics
endpoint is available by default on port:8945
(configurable by theaddress
flag).