Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new /metrics endpoint to allow monitoring of addon-resizer #6916

Conversation

raywainman
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds Prometheus metrics to addon-resizer, allowing monitoring of overall health. Initial implementation adds a single metric called addon_resizer_execution_outcome which is a simple counter metric that tracks the outcome of every addon-resizer loop (for example, whether addon-resizer actually updated the deployment for metrics-server).

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Follow up to #6764 where addon-resizer is made compatible to run in the control plane.

Does this PR introduce a user-facing change?

-Expose new `/metrics` endpoint in addon-resizer to expose health metrics that are useful for monitoring purposes.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

To use:

  • Ensure the expose-metrics flag is set to true.
  • The /metrics endpoint is available by default on port :8945 (configurable by the address flag).

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 11, 2024
@raywainman
Copy link
Contributor Author

/assign chelseychen

@k8s-ci-robot
Copy link
Contributor

@raywainman: GitHub didn't allow me to assign the following users: chelseychen.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign chelseychen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chelseychen
Copy link

LGTM, thanks for the change!

addon-resizer/nanny/metrics/metrics.go Outdated Show resolved Hide resolved
addon-resizer/nanny/main/pod_nanny.go Outdated Show resolved Hide resolved
@kwiesmueller
Copy link
Member

/lgtm
/hold
In case you want to respond to the comments. I don't think they are blocking (even though a test would be nice, but addon-manager doesn't have too many). Feel free to remove the hold if ack.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link
Member

@kwiesmueller kwiesmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwiesmueller, raywainman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@raywainman
Copy link
Contributor Author

/remove-hold

Resolved comments and Kevin re-LGMT'ed and approved.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 69675bd into kubernetes:addon-resizer-release-1.8 Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants