Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vpa-up.sh to point to vpa 1.2.0 in 1.2 release branch #7131

Closed
wants to merge 47 commits into from
Closed

Update vpa-up.sh to point to vpa 1.2.0 in 1.2 release branch #7131

wants to merge 47 commits into from

Conversation

raywainman
Copy link
Contributor

Part of #7098.

comtalyst and others added 30 commits July 21, 2024 11:44
@comtalyst
refactor: upstream most of Azure managed CAS changes in cloudprovider…
2eb6cbe 
…/azure
@kamalkraj
Update aws_cloud_provider.go
817861b
@k8s-ci-robot
Merge pull request kubernetes#7099 from raywainman/patch-4
3914bde 
Update version.go for VPA 1.2.0 release
@bskiba
Extract getting nodes to delete for atomic node groups
14b3357 
Extract logic for overriding nodes to delete when deleting
nodes from a ZeroOrMaxNodeScaling node group.
Simplifies the code and removes code duplication.
@vbhargav875
Set State to InstanceCreating for nodes that failed to join cluster
0dd9ea5
@k8s-ci-robot
Merge pull request kubernetes#7096 from vbhargav875/oci_oke_add_insta…
e58a744 
…nce_creating_state

Set State to InstanceCreating for nodes that failed to join cluster
@Bryce-Soghigian
feat: add bryce-soghigian to the list of azure owners
b40e719
@Bryce-Soghigian
fix: removing approver
5d79ca6
@k8s-ci-robot
Merge pull request kubernetes#7003 from comtalyst/comtalyst/azure-cha…
45dfba4 
…nges-from-managed-master

refactor: upstream most of Azure managed CAS changes in cloudprovider/azure
@k8s-ci-robot
Merge pull request kubernetes#7068 from bskiba/cleanup-for-stockout-2
921b399 
Extract getting nodes to delete for atomic node groups
@k8s-ci-robot
Merge pull request kubernetes#7097 from kamalkraj/patch-1
392cef8 
CA: AWS add support for Nvidia L4 GPU instances
@Bryce-Soghigian
feat: HasInstance implementation
c90a262
@Bryce-Soghigian
fix: ci lint
17cee14
@Bryce-Soghigian
refactor: cloudprovider HasInstance should use case sensitive instanc…
3ee8d1c 
…e group lookup
@Bryce-Soghigian
feat: using NodeGroupForNode for the azure provider has instance impl…
9be9604 
…ementation
@Bryce-Soghigian
fix: ci lint
27e3e97 
fix: ci
@Bryce-Soghigian
wip: HasInstance impl based on a fork of NodeGroupForNode
39d0882
@Bryce-Soghigian
refactor: refactoring tests and sharing validation between ngfornode …
e48a743 
…+ hasinstance
@Bryce-Soghigian
test: removing commented out test
24fbfff
@Bryce-Soghigian
ci: fix formatting
a48dd71
@Bryce-Soghigian
fix: properly handling unmanaged nodes
20129ed
@Bryce-Soghigian
fix: removing unused helper
15a0e40
@Bryce-Soghigian
fix: using provider id to get scaleset name
79ac01e
@Bryce-Soghigian
fix: putting items into the set as lowercase to avoid mismatch in lookup
9b8691d
@Bryce-Soghigian @tallaxes
Update cluster-autoscaler/cloudprovider/azure/azure_cloud_provider.go
5b4255f 
Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
@Bryce-Soghigian
fix: always fallback if we are unsure an instance is in the cache
e7a2881
@Bryce-Soghigian
test: adding back in TestNodeGroupForNodeWithNoProviderID
349c80b
@Bryce-Soghigian
refactor: removing log lines since this will spam for non-autoscaled …
1a8bfb6 
…nodes
@Bryce-Soghigian
refactor: removing dead code
2c065f6
@Bryce-Soghigian
fix: simplifying logic since we no longer distinguish on delete
476e275
Bryce-Soghigian and others added 17 commits July 31, 2024 09:33
@Bryce-Soghigian
Update cluster-autoscaler/cloudprovider/azure/azure_cache.go
0793422
@Bryce-Soghigian
test: renaming test to better reflect the scenario
eba8653
@Bryce-Soghigian @tallaxes
Update cluster-autoscaler/cloudprovider/azure/azure_cache.go
3cc1dcf 
Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
@Bryce-Soghigian
refactor: removing shared helpers since they are no longer shared and…
59356d5 
… didnt make any sense in the first place
@Bryce-Soghigian
refactor: removing unused code and adding a test for has instance hap…
008161e 
…py path
@Bryce-Soghigian
Update cluster-autoscaler/cloudprovider/azure/azure_cache.go
25a4f9a
@Bryce-Soghigian
ci: lint
4a4ea9e
@Bryce-Soghigian @tallaxes
Update cluster-autoscaler/cloudprovider/azure/azure_cache.go
34a26ee 
Co-authored-by: Alex Leites <18728999+tallaxes@users.noreply.github.com>
@k8s-ci-robot
Merge pull request kubernetes#6956 from Bryce-Soghigian/bsoghigian/az…
1ae8bcc 
…ure/has-instance-impl

feat: Azure Provider HasInstance implementation
@aagusuab
Adding temporary multizone-nodepool support for CAS
c1d30e7
@k8s-ci-robot
Merge pull request kubernetes#7100 from Bryce-Soghigian/bsoghigian/ap…
616930b 
…prover-for-robin

feat: add bryce-soghigian to the list of azure owners
@raywainman
Bump VPA version to 1.2.0
ff61039
@k8s-ci-robot
Merge pull request kubernetes#7108 from raywainman/master-local
f275c51 
Bump VPA version to 1.2.0 in main branch
@k8s-ci-robot
Merge pull request kubernetes#7013 from aagusuab/multi-nodepool-upstr…
3e09d37 
…eam-fix

Adding temporary multizone-nodepool support for CAS
@rakechill
Regenerate static sku list (master)
4891ddc
@k8s-ci-robot
Merge pull request kubernetes#7126 from rakechill/rakechill/static-sk…
d2aca8b 
…u-regen

Regenerate azure static sku list (master)
@raywainman
Update vpa-up.sh to 1.2.0 in 1.2 release branch
15fba72 
Part of kubernetes#7098.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raywainman
Once this PR has been reviewed and has the lgtm label, please assign kwiesmueller, x13n for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/oci Issues or PRs related to oci provider area/vertical-pod-autoscaler labels Aug 6, 2024
@raywainman raywainman closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

Assignees
No one assigned
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/oci Issues or PRs related to oci provider area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@raywainman @k8s-ci-robot @comtalyst @kamalkraj @bskiba @vbhargav875 @Bryce-Soghigian @aagusuab @rakechill