-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom HCLOUD_ENDPOINT in cluster-autoscaler Hetzner manager #7285
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @kamushadenes! |
Hi @kamushadenes. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Awesome! Very curious to see your proxy, feel free to submit it to our awesome-list once you are ready 🚀 /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, kamushadenes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for merging @apricote ! When can we likely expect a release containing this change? |
This is currently in I am not sure what the official policy is on backporting features to older release series. |
# Context [We](https://github.com/altinity) have developed a soon-to-be-open-source proxy that forces specific labels in order to provide scoped API access, and that doesn't expose the real API token. This was created to have better control of resources inside the same project (as API tokens currently lack granularity), and to be able to use a single project securely, given that it isn't possible to create a project via the API. One of it's operating modes is using JWT as a virtual self-validating token, which can't have a fixed size. This support is required to make full use of it inside a Kubernetes cluster. The feature is behind a default-false flag so it shouldn't interfere with current behavior. # Related kubernetes/autoscaler#7285 hetznercloud/csi-driver#724
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support to the HCLOUD_ENDPOINT environment variable, following what's used by other projects like https://github.com/hetznercloud/hcloud-cloud-controller-manager and https://github.com/hetznercloud/csi-driver.
Which issue(s) this PR fixes:
Fixes #7284
Special notes for your reviewer:
We have developed a soon-to-be-open-source proxy that forces specific labels in order to provide scoped API access. This support is required to make full use of it inside a Kubernetes cluster.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: