contributors/devel/sig-release: use dl.k8s.io where possible #5893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the kubernetes-versions guide to avoid referencing `gsutil` and URI's that have GCS bucket names hardcoded in them where possible. We don't have a CLI accessible way to list the contents of a given build through dl.k8s.io, so it was necessary to keep it there. Anything else that uses http or https to download kubernetes artifacts should always use dl.k8s.io. It greatly reduces the amount of code that will need to change whenever a different location is used (GCS bucket rename, some other backing store, etc.)
k8s-ci-robot
added
size/L
k8s-ci-robot
added
area/developer-guide
42 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the kubernetes-versions guide to avoid referencing
gsutilandURI's that have GCS bucket names hardcoded in them where possible.
We don't have a CLI accessible way to list the contents of a given build
through dl.k8s.io, so it was necessary to keep it there.
Anything else that uses http or https to download kubernetes artifacts
should always use dl.k8s.io. It greatly reduces the amount of code that
will need to change whenever a different location is used (GCS bucket
rename, some other backing store, etc.)
There are a few other
kubernetes-releasereferences in this repo thatcould be changed, but they're all historical or blockaded, so the
version markers doc was the only file that needed changes
This is part of kubernetes/k8s.io#2318