Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-signal: use k8s-release-dev for CI builds #1642

Merged
merged 1 commit into from
Jul 29, 2021
Merged

ci-signal: use k8s-release-dev for CI builds #1642

merged 1 commit into from
Jul 29, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 29, 2021

What type of PR is this:

/kind cleanup
/kind documentation

What this PR does / why we need it:

kubernetes-release-dev is deprecated and has no new builds as of v1.23

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

Related:

@spiffxp
ci-signal: use k8s-release-dev for CI builds
fafd7e0 
kubernetes-release-dev is deprecated and has no new builds as of v1.23
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jul 29, 2021
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 29, 2021

/priority important-soon
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 29, 2021
@spiffxp spiffxp mentioned this pull request Jul 29, 2021
Closed
42 tasks
justaugustus
justaugustus approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@spiffxp -- as a follow-up, should we prefer curl in docs over gsutil?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0ce8b22 into kubernetes:master Jul 29, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 29, 2021

I mean there's a part of me that wonders if this shouldn't just link to https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/kubernetes-versions.md instead of having similar content

But I defer that to folks here, I'm trying to keep my attention focused elsewhere vs sprawling into doc rewrites today

@spiffxp spiffxp deleted the use-k8s-release-dev branch July 29, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@droslean droslean Awaiting requested review from droslean

@mkorbi mkorbi Awaiting requested review from mkorbi

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @justaugustus