-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove klog specific command line arguments from Kubernetes components #2845
Comments
/sig arch |
@serathius: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig architecture |
Hi @serathius! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:
All good now! Thanks! |
/stage alpha |
/tracked yes |
Hi @serathius Ping! As a reminder your PR (#2912 ) needs to merge by EOD PST tomorrow September 9th to be included in the 1.23 Release. After that time you will need to request an exception. Lmk if you need anything, |
* Move KEP-2845 to implementable * Add PRR for kubernetes#2845 * Remove mention of --logtostdout flag in kubernetes#2845 * KEP kubernetes#2485: Require splitting stdout/stderr to Json format * Add pohly as reviewer for KEP 2845 * kubernetes#2845 Update PRR * kubernetes#2845 Add dims as SIG arch approver
Hi @serathius 👋 1.23 Docs shadow here. This enhancement is marked as 'Needs Docs' for the 1.23 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT. Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thanks! |
@pohly I have split Alpha work by milestones. I have assigned to you
Please confirm and let me know when you will have PR for them. |
Marked "Klog can be configured without registering flags" as resolved as technically kubernetes/kubernetes#105076 moved klog flag registration into component-base allowing us to register only flags we want. |
That's okay. As discussed in https://kubernetes.slack.com/archives/C020CCMUEAX/p1635445845031900, both will be solved by adding fields for -v and -vmodule to |
/assign |
Hello @serathius @pohly I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022 Please ensure the following items are completed:
For note, the status of this enhancement is currently marked as
Thank you! |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale The goal is to complete the deprecation in 1.26. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
@pohly should this be graduated to stable now that the flags have been removed in k/k? |
Yes, I think we could do that. |
|
Could we change the issue title to "Remove klog specific command line arguments from Kubernetes components"? |
/title Remove klog specific command line arguments from Kubernetes components |
/assign @dgrisonnet to find klog PRs |
@logicalhan: GitHub didn't allow me to assign the following users: PRs, to, find, klog. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing since the KEP is now stable and implemented. |
This is needed to accomodate CAPI 1.4 coming in 4.14 payload https://main.cluster-api.sigs.k8s.io/developer/providers/migrations/v1.3-to-v1.4.html, kubernetes/enhancements#2845, kubernetes/kubernetes#112120
This is needed to accomodate CAPI 1.4 coming in 4.14 payload https://main.cluster-api.sigs.k8s.io/developer/providers/migrations/v1.3-to-v1.4.html, kubernetes/enhancements#2845, kubernetes/kubernetes#112120
Enhancement Description
One-line enhancement description (can be used as a release note): Deprecate klog specific flags in Kubernetes components
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/2845-deprecate-klog-specific-flags-in-k8s-components/README.md
Discussion Link: https://groups.google.com/g/kubernetes-dev/c/dAzHAdxe6ok
Primary contact (assignee): serathius
Responsible SIGs: sig-instrumentation, sig-arch
Enhancement target (which target equals to which milestone):
Alpha
k/enhancements
) update PR(s): KEP-2845: Initial draft #2846 Move KEP-2845 to implementable #2912k/k
) update PR(s):k/website
) update PR(s): logging: structured logging, klog deprecation website#30505Beta
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):Stable
k/enhancements
) update PR(s): update status of klog flag deprecation #3650k/k
) update PR(s): logs: remove deprecated klog flags kubernetes#112120k/website
) update(s):The text was updated successfully, but these errors were encountered: