logging: structured logging, klog deprecation #30505
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: c307316 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6195fe8aea995c0007ff7b22 |
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
sig/docs
| @@ -22,11 +22,59 @@ generates log messages for the Kubernetes system components. | |||
|
|
|||
| For more information about klog configuration, see the [Command line tool reference](/docs/reference/command-line-tools-reference/). | |||
There was a problem hiding this comment.
What is the right approach for updating the command line tools reference? Manually edit the HTML table?
That needs to be part of this PR.
/hold
There was a problem hiding this comment.
We typically update all generated docs during the release, separately from human-made PRs that accompany changes in that release.
If that's true here to, we can /unhold.
There was a problem hiding this comment.
Sounds like I don't need to worry about the reference docs then.
/unhold
k8s-ci-robot
added
the
do-not-merge/hold
| | Merge stderr and stdout, write to stdout | `2>&1` | `kube-log-runner` (default behavior) | | ||
| | Redirect both into log file | `1>>/tmp/log 2>&1` | `kube-log-runner -log-file=/tmp/log` | | ||
| | Copy into log file and to stdout | `2>&1 \| tee -a /tmp/log` | `kube-log-runner -log-file=/tmp/log -also-stdout` | | ||
| | Redirect only stdout into log file | `>/tmp/log` | `kube-log-runner -log-file=/tmp/log -redirect-stderr=false` | |
There was a problem hiding this comment.
We need to check that this complex table is rendered correctly. It works in GitHub, but I am not sure about the Kubernetes HTML.
Where can I find the preview pages?
There was a problem hiding this comment.
Here's the preview: https://deploy-preview-30505--kubernetes-io-vnext-staging.netlify.app/docs/concepts/cluster-administration/system-logs/#klog
(To find this: start from #30505 (comment) and click “Deploy preview”)
There was a problem hiding this comment.
Hmm, "Deploy preview" is just plain text when I look at that comment.
I see a link to the deploy log, but that also doesn't link to the preview.
Anyway, rendering looks good.
There was a problem hiding this comment.
Ah sorry. It turns out that as a privileged user I get that link and other folks don't.
Not sure why (I don't see it as confidential and the URLs are predictable).
I might nudge Netlify about that if I get time. It's a busy period though!
|
/sig instrumentation |
k8s-ci-robot
added
the
sig/instrumentation
|
/assign |
This is primarily the docs PR for - alpha: kubernetes/enhancements#2845 - beta: kubernetes/enhancements#1602 But as it touches the file, it also updates the examples and explanations to reflect some recent observations.
pohly
force-pushed
the
structured-logging-1.23
branch
from
14ff32f
to
c307316
Compare
pohly
changed the title
k8s-ci-robot
removed
the
do-not-merge/hold
|
/assign @serathius |
|
LG from technical standpoint. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 586c9a34ac508b2c948c0452d8e6bacdefd8b5bf
|
|
/cc @jlbutler |
|
/assign @reylejano For approval. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlbutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This is primarily the docs PR for
But as it touches the file, it also updates the examples and explanations to
reflect some recent observations.