Update kep template

[MorrisLaw]

This PR is to address the following needs that arose from this slack convo:

• "Add an "Open Questions" section to KEPs; in addition to the unresolved tag, easy win, all that has to be done is adding the field"
• "Make the test plan section more specific—get feedback from SIG Testing and SIG Arch (conformance) about what they’re looking for [Conformance group ack’ed request, working on it]"
• "Use participating or participating-groups, instead of participating-sigs (other governance bodies could be stakeholders)"

I'm not 100% sure how this information should be added, so here is my attempt at doing so.

[ehashman]

/assign

[kikisdeliveryservice]

we changed sigs to groups, but the explanatory note below still only refers to sigs.. maybe "A list of SIGs, WGs and other groups..." (is there something other than a SIG/WG?)

[MorrisLaw]

Ahhh nice catch @kikisdeliveryservice !

I'll update this

[johnbelamaric]

there are committees too (e.g., code of conduct committee)

[johnbelamaric]

Couple things:

1. I would just change the template, not every KEP
2. To support that, participating-sigs could still be valid but removed from the template.
3. You'll need to update the kepval code to validate against other groups, not just the list of SIGs. If both groups and sigs are defined, you should puke on that too.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MorrisLaw
To complete the pull request process, please assign jeremyrickard after the PR has been reviewed.
You can assign the PR to them by writing /assign @jeremyrickard in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• keps/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@MorrisLaw: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-enhancements-verify	946926c	link	/test pull-enhancements-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[MorrisLaw]

If both groups and sigs are defined, you should puke on that too.

Could you clarify this please @johnbelamaric. I'm not too familiar with kepval. But are you suggesting to:

• Update the Proposal struct, here, to include ParticipatingWGs and ParticipatingCommittees ?
• Extend this struct and this Validate function to validate groups?

Also, how do we determine groups @johnbelamaric @kikisdeliveryservice? I found this description of community groups. Should we also include User Groups? I'm hoping to find a finite list, other groups seems a bit too ambiguous, especially if we hope to validate against that.

[MorrisLaw]

@johnbelamaric ^

[johnbelamaric]

If both groups and sigs are defined, you should puke on that too.

Could you clarify this please @johnbelamaric. I'm not too familiar with kepval. But are you suggesting to:

• Update the Proposal struct, here, to include ParticipatingWGs and ParticipatingCommittees ?

No, I don't think we need to differentiate. I am just saying let's not change every KEP to say "group", but instead allow "sigs" or "groups". Maybe others will disagree though as it does make Proposals a little hacky.

• Extend this struct and this Validate function to validate groups?

Also, how do we determine groups @johnbelamaric @kikisdeliveryservice? I found this description of community groups. Should we also include User Groups? I'm hoping to find a finite list, other groups seems a bit too ambiguous, especially if we hope to validate against that.

No, those are for kepctl query command. But the good news is it looks like all groups are already in the validation: https://github.com/kubernetes/enhancements/blob/master/pkg/legacy/keps/validations/yaml.go#L88

You'll need to update the validations there to allow the sigs or groups, and to fail if more than one is filled out and they are not the same (you could set the empty one to the same value as the filled one).

[k8s-ci-robot]

@MorrisLaw: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ehashman]

I'm going to close this for now and suggest we rebase when you have time to pick this back up, @MorrisLaw!

/close

[k8s-ci-robot]

@ehashman: Closed this PR.

In response to this:

I'm going to close this for now and suggest we rebase when you have time to pick this back up, @MorrisLaw!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.