Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kep template #2154

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keps/0001-kubernetes-enhancement-proposal-process.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ Metadata items:
this SIG will take responsibility for the bulk of those artifacts.
* Sigs are listed as `sig-abc-def`, where the name matches the
directory entry in the `kubernetes/community` repo.
* **participating-sigs** Optional
* **participating-groups** Optional
* A list of SIGs that are involved or impacted by this KEP.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we changed sigs to groups, but the explanatory note below still only refers to sigs.. maybe "A list of SIGs, WGs and other groups..." (is there something other than a SIG/WG?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh nice catch @kikisdeliveryservice !

I'll update this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are committees too (e.g., code of conduct committee)

* A special value of `kubernetes-wide` will indicate that this KEP has impact
across the entire project.
Expand Down
7 changes: 6 additions & 1 deletion keps/NNNN-kep-template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -254,13 +254,18 @@ proposal will be implemented, this is the place to discuss them.
Consider the following in developing a test plan for this enhancement:
- Will there be e2e and integration tests, in addition to unit tests?
- How will it be tested in isolation vs with other components?
- What will be the feature keyword for planned e2e/integration tests?

No need to outline all of the test cases, just the general strategy. Anything
that would count as tricky in the implementation, and anything particularly
challenging to test, should be called out.

All code is expected to have adequate tests (eventually with coverage
expectations). Please adhere to the [Kubernetes testing guidelines][testing-guidelines]
expectations). There should also be an easy way to filter tests for a
specific component in your KEP. Links to testgrid, filtered on your
feature component, is particular useful for KEP reviewers.

Please adhere to the [Kubernetes testing guidelines][testing-guidelines]
when drafting this test plan.

[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
Expand Down
7 changes: 6 additions & 1 deletion keps/NNNN-kep-template/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kep-number: NNNN
authors:
- "@jane.doe"
owning-sig: sig-xyz
participating-sigs:
participating-groups:
- sig-aaa
- sig-bbb
status: provisional|implementable|implemented|deferred|rejected|withdrawn|replaced
Expand Down Expand Up @@ -49,3 +49,8 @@ disable-supported: true
# The following PRR answers are required at beta release
metrics:
- my_feature_metric

# The following open questions
open-questions:
- question: MyQuestion
- unresolved: true
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Custom endpoints support for AWS Cloud Provider
authors:
- "@micahhausler"
owning-sig: sig-cloud-provider
participating-sigs:
participating-groups:
- sig-cloud-provider
reviewers:
- "@justinsb"
Expand Down
2 changes: 1 addition & 1 deletion keps/provider-aws/20190501-aws-nlb-beta.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: graduate-aws-nlb-to-beta
authors:
- "@M00nF1sh"
owning-sig: sig-cloud-provider
participating-sigs:
participating-groups:
reviewers:
- "@dnishi"
approvers:
Expand Down
2 changes: 1 addition & 1 deletion keps/provider-aws/aws-lb-prefix-annotation.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: AWS LoadBalancer Prefix
authors:
- "@minherz"
owning-sig: sig-cloud-provider
participating-sigs:
participating-groups:
reviewers:
- TBD
approvers:
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/0006-apply.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Apply
authors:
- "@lavalamp"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
- sig-cli
reviewers:
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/0015-dry-run.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Dry-run
authors:
- "@apelisse"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
- sig-cli
reviewers:
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/1040-priority-and-fairness/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@MikeSpreitzer"
- "@yue9944882"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- wg-multitenancy
- sig-scheduling
status: implementable
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/1164-remove-selflink/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kep-number: 1164
authors:
- "@wojtek-t"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-scalability
reviewers:
- "@liggitt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kep-number: 1623
authors:
- "@deads2k"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
- sig-apps
- sig-architecture
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/1693-warnings/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kep-number: 1693
authors:
- "@liggitt"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-architecture
- sig-cli
- sig-instrumentation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ title: Manifest based registration of Admission webhooks
authors:
- "@vivekbagade"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-instrumentation
reviewers:
- "@liggitt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kep-number: 1904
authors:
- "@wojtek-t"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-scalability
status: implementable
creation-date: 2020-07-23
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20180415-crds-to-ga.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors:
- "@roycaihw"
- "@sttts"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
- sig-architecture
reviewers:
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20180731-crd-pruning.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Pruning for Custom Resources
authors:
- "@sttts"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
reviewers:
- "@deads2k"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190129-legacyflag.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: legacyflags
authors:
- "@mtaufen"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-architecture
- sig-cluster-lifecycle
- wg-component-standard
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190206-watch-bookmark.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Watch Bookmark
authors:
- "@wojtek-t"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-scalability
reviewers:
- "@jpbetz"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190226-network-proxy.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@cheftako"
- "@anfernee"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-network
- sig-cloud-provider
reviewers:
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190322-server-side-get-to-ga.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Graduate Server-side Get and Partial Objects to GA
authors:
- "@smarterclayton"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-cli
reviewers:
- "@lavalamp"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190325-unions.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Union types
authors:
- "@apelisse"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
reviewers:
- "@sttts"
- "@lavalamp"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Less object serializations
authors:
- "@wojtek-t"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-scalability
reviewers:
- "@jpbetz"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190425-crd-conversion-webhook.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@mbohlool"
- "@erictune"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
reviewers:
- "@lavalamp"
- "@deads2k"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190425-structural-openapi.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@sttts"
- "@mbohlool"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
reviewers:
- "@liggitt"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190426-crd-defaulting.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Defaulting for Custom Resources
authors:
- "@sttts"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
reviewers:
- "@deads2k"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190603-immutable-fields.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@apelisse"
- "@sttts"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
reviewers:
- "@erictune"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190607-owner-ref.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: OwnerReference Resource Field
authors:
- "@deads2k"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
reviewers:
- "@sttts"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190612-crd-group-protection.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: k8s.io Group Protection
authors:
- "@deads2k"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
- sig-architecture
reviewers:
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190625-api-compression-to-ga.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Graduate API gzip compression support to GA
authors:
- "@smarterclayton"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-cli
reviewers:
- "@lavalamp"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20190927-insecure-backend-proxy.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Insecure Backend Proxy
authors:
- "@deads2k"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
- sig-auth
- sig-cli
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@jpbetz"
- "@wojtek-t"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-scalability
reviewers:
- "@wojtek-t"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-api-machinery/20200123-client-go-ctx.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@mikedanese"
- "@maleck13"
owning-sig: sig-api-machinery
participating-sigs:
participating-groups:
- sig-api-machinery
approvers:
- "@deads2k"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-apps/0026-ttl-after-finish.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: TTL After Finished
authors:
- "@janetkuo"
owning-sig: sig-apps
participating-sigs:
participating-groups:
- sig-api-machinery
reviewers:
- "@enisoc"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@bradhoekstra"
- "@kongslund"
owning-sig: sig-apps
participating-sigs:
participating-groups:
reviewers:
- TBD
approvers:
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-apps/0032-portable-service-definitions.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ title: Portable Service Definitions
authors:
- "@mattfarina"
owning-sig: sig-apps
participating-sigs:
participating-groups:
- sig-service-catalog
reviewers:
- "@carolynvs"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-apps/1591-daemonset-surge/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kep-number: 1591
authors:
- "@smarterclayton"
owning-sig: sig-apps
participating-sigs:
participating-groups:
- sig-scheduling
- sig-node
reviewers:
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-apps/19-Graduate-CronJob-to-Stable/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@barney-s"
- "@soltysh"
owning-sig: sig-apps
participating-sigs:
participating-groups:
- sig-scalability
status: implementable
creation-date: 2019-04-18
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-apps/20190226-maxunavailable-for-statefulsets.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Implement maxUnavailable for StatefulSets
authors:
- "@krmayankk"
owning-sig: sig-apps
participating-sigs:
participating-groups:
- sig-apps
reviewers:
- "@janetkuo"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: graduate-pod-disruption-budget-to-stable
authors:
- "@bsalamat"
owning-sig: sig-apps
participating-sigs:
participating-groups:
- sig-scheduling
reviewers:
- "@liggitt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: pdb-support-for-custom-resources-with-scale-subresource
authors:
- "@mortent"
owning-sig: sig-apps
participating-sigs:
participating-groups:
- sig-scheduling
- sig-autoscaling
reviewers:
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-architecture/1194-prod-readiness/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kep-number: 1194
authors:
- "@johnbelamaric"
owning-sig: sig-architecture
participating-sigs:
participating-groups:
- sig-release
reviewers:
- "@derekwaynecarr"
Expand Down
2 changes: 1 addition & 1 deletion keps/sig-architecture/1618-conformance-profiles/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ authors:
- "@johnbelamaric"
- "@jefftree"
owning-sig: sig-architecture
participating-sigs:
participating-groups:
status: provisional
creation-date: 2020-03-18
reviewers:
Expand Down
Loading