[WIP do not merge] Kube-Proxy Library: Breakout a KPNG-like interface "kube proxy lib" from #2104 #3649

jayunit100 · 2022-11-08T14:26:42Z

Break out KEP from #2104

Adding details about how proxies work w/ and w/o the fullstate initial wave of fixes from dan's review updaedd diffstore explanation and typo fix, moved it updates to userstories and fixes to DiffState bundling logic removed exsiting Run() logic, Fix some spelling and typos Add section on the different types of client sinks. Signed-off-by: astoycos <astoycos@redhat.com> Add note about separate node kpng-brain and its fragility as a real feature Update README.md Refactoring Kube-Proxy, mega-commit Co-authored-by: mcluseau <mikael.cluseau@gmail.com> Co-authored-by: jayunit100 <jvyas@vmware.com> Co-authored-by: kbabben <knabben@vmware.com> Co-authored-by: rajas kakodkar <rkakodkar@vmware.com>

…paration of the APIServer uplink

k8s-ci-robot · 2022-11-08T14:26:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jayunit100
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval by writing /assign @thockin in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

keps/sig-network/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

astoycos · 2022-11-11T14:05:33Z

/cc

danwinship · 2022-11-11T18:15:31Z

keps/sig-network/2104-kube-proxy-lib/README.md

+should be approved by the remaining approvers and/or the owning SIG (or
+SIG Architecture for cross-cutting KEPs).
+-->
+# KEP-2104: kube-proxy library (KEP-2104, breakout)


we'll probably want a new KEP number for this

I guess we'd need a new issue for this right @jayunit100 ?

ya, i guess for the last thing we do we can clean that ... lets get consensus on the impl first tho i think b4 we gift wrap that part?

keps/sig-network/2104-kube-proxy-lib/README.md

danwinship · 2022-11-29T16:11:52Z

keps/sig-network/2104-kube-proxy-lib/README.md

+
+#### Story 2
+
+As a Kubernetes maintainer, I don't want to have to understand the internals of a networking backend in order to simulate or write core updates to the logic of the kube-proxy locally.


This is a fairly small use case. In fact, it's pretty much limited to topology-related features, where all you care about is restricting the endpoints that get used on a given node. For just about anything else, any change to the core is going to need to be matched with new code in the backends as well.

yeah, updated as a svc proxy maint , pushing shortly

danwinship · 2022-11-29T16:13:41Z

keps/sig-network/2104-kube-proxy-lib/README.md

+- Exemplify the use of such a repository in a mock "backend" which uses the repository to process and respond to changes in the Kubernetes networking state.
+- Define a policy around versioning and releasing of "kube-proxy-lib".
+- Create a CI system that runs in test-grid which tests kube-proxy-lib compatibility with the latest Kubernetes releases continuously, and which can be used to inform API changes for regressions that break "kube-proxy-lib".
+- Enable the eventual *replacement* of the k/k/pkg/proxy serviceChangeTracker and endpointsChangeTracker related caching structures inside of in-tree kube proxy with this generic library.


Maybe point out that the existing code has hard-to-fix bugs. Eg, kubernetes/kubernetes#112604

danwinship · 2022-11-29T16:14:28Z

keps/sig-network/2104-kube-proxy-lib/README.md

+- sending the full-state could be resource consuming on big clusters, but it should still be O(1) to
+  the actual kernel definitions (the complexity of what the node has to handle cannot be reduced
+  without losing functionality or correctness).


It is completely unclear what this means, in the context of this KEP.

danwinship · 2022-11-29T16:16:50Z

keps/sig-network/2104-kube-proxy-lib/README.md

+
+No risks, because we arent removing the in tree proxy as part of this repo, but rather, proposing a library for kube proxy extenders
+to use optionally.  There may be risks, eventually, if we write another KEP to *replatform* sig-networks k/k/pkg/proxy implementations
+on top of this library, but that would be in a separate KEP. 


I don't think it makes sense for that to be a separate KEP. IMO this project is only interesting for SIG Network if it is going to replace our existing shared proxy code. (Yes, the code would be useful for third parties even if SIG Network wasn't using it in the k8s core, but it wouldn't make sense for SIG Network to own the code in that case; it should just be a third-party project.)

Fair point but, in the interest of "building something that is uncontraversial as a first step", How strongly do you feel about this ? If i made this argument:

"sig network needs b"

"b needs a"

thus were going to make "sig-network/a" as a stepping stone to us being able to build "sig-network/b"

by the way "sig-network/b" is somethin lots of people want, so even if we get hit by a bus after making "b", and we never get around to "a", we still have a useful intermediate deliverable....

Is that digestible ? or does it sit funny w/ you ?

What I'm saying is that I don't think the library can be definitely "uncontroversial" and "a useful intermediate deliverable" unless we know that it is suited to replacing pkg/proxy.

I'm not saying we have to deliver the library and the updated iptables proxy in the same release, I'm saying that rather than doing:

come up with a plan for the library

implement the library

come up with a plan to replace pkg/proxy with the new library

replace pkg/proxy with the new library

we need to do

come up with a plan for the library

come up with a plan to replace pkg/proxy with the new library

implement the library

replace pkg/proxy with the new library

gotcha, ok updated as a risk (and updated the goals to reflect)

danwinship · 2022-11-29T16:18:22Z

keps/sig-network/2104-kube-proxy-lib/README.md

+
+###### Will enabling / using this feature result in introducing new API types?
+
+Yes. There will be an in-memory API that is supported by this library, that is incremented overr time


No. The question is about kubernetes API types, not about golang APIs.

ok, added "No" + clarified

astoycos · 2022-12-02T15:43:13Z

/assign

Co-authored-by: Dan Winship <danwinship@redhat.com>

aojea · 2022-12-08T17:46:43Z

/cc

jayunit100 · 2022-12-08T21:40:46Z

@astoycos I'd say get folks to agree on the content then fix the details like issue and kep number after... your call tho

astoycos · 2022-12-08T22:02:30Z

+1 @jayunit100 I'm running through Dan's comments that are still open and fixing some small stuff I should have a commit up by tonight then I'll keep pushing others on if the context makes sense

jayunit100 · 2022-12-09T17:10:34Z

feel free to YOLO push @astoycos thanks !

This update provides some fixes and review comment resolutions from Dan. It also clarifies where and what the proposed library would look like and the role it would initially serve for existing proxies. Also fix verification tests :) Signed-off-by: Andrew Stoycos <astoycos@redhat.com>

astoycos · 2022-12-09T20:36:20Z

/assign

astoycos · 2022-12-09T20:36:57Z

Pushed some updates based on @danwinship comments and the discussion from the kpng meeting this morning

astoycos · 2023-01-26T22:19:12Z

/close

Closed in favor of #3788

k8s-ci-robot · 2023-01-26T22:19:18Z

@astoycos: Closed this PR.

In response to this:

/close

Closed in favor of #3788

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mcluseau and others added 8 commits September 24, 2022 00:36

Add user story that clarifies the performance tuning available via se…

d6767c2

…paration of the APIServer uplink

add user story about new languages

5988636

Update README.md

7bd05dc

Update README.md

081361b

update TOC

599a2ef

kube-proxy-lib initial stab at minimal KEP will add details later

2a66e44

cleanup

517a213

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels Nov 8, 2022

k8s-ci-robot requested review from dcbw and thockin November 8, 2022 14:26

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2022

jayunit100 added 3 commits November 8, 2022 14:34

Updates

ee08731

retitle

3aaac50

link to tims slides

2023058

jayunit100 changed the title ~~Kube-Proxy Library: Breakout a KPNG-like interface "kube proxy lib" from #2104~~ [WIP do not merge] Kube-Proxy Library: Breakout a KPNG-like interface "kube proxy lib" from #2104 Nov 8, 2022

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2022

k8s-ci-robot requested a review from astoycos November 11, 2022 14:05

note from per and dan about long term goals

0afe468

jayunit100 mentioned this pull request Nov 11, 2022

Implement a library of Diff store and Watching utilities (that can be used to build new kube-proxy implementations) kubernetes/kube-proxy#16

Closed

danwinship reviewed Nov 29, 2022

View reviewed changes

k8s-ci-robot assigned astoycos Dec 2, 2022

jayunit100 and others added 3 commits December 6, 2022 10:17

Update keps/sig-network/2104-kube-proxy-lib/README.md

5b0d390

Co-authored-by: Dan Winship <danwinship@redhat.com>

Update keps/sig-network/2104-kube-proxy-lib/README.md

9172111

Co-authored-by: Dan Winship <danwinship@redhat.com>

Update keps/sig-network/2104-kube-proxy-lib/README.md

793087d

Co-authored-by: Dan Winship <danwinship@redhat.com>

jayunit100 and others added 3 commits December 6, 2022 10:18

Apply suggestions from code review

0df8afc

Co-authored-by: Dan Winship <danwinship@redhat.com>

Update README.md

c7586d0

Update README.md

236794b

k8s-ci-robot requested a review from aojea December 8, 2022 17:46

astoycos force-pushed the kube-proxy-lib branch from 63c5315 to fda9787 Compare December 9, 2022 20:39

astoycos mentioned this pull request Dec 13, 2022

KEP-3685: Move EndpointSlice Reconciler into Staging #3686

Merged

danwinship mentioned this pull request Jan 16, 2023

Move kube-proxy networking utilities to staging kubernetes/kubernetes#112886

Closed

This was referenced Jan 26, 2023

Migrate Shared Kube-Proxy Code into Staging #3786

Closed

KEP-3786: Migrate Shared Kube-Proxy code into staging #3788

Closed

k8s-ci-robot closed this Jan 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP do not merge] Kube-Proxy Library: Breakout a KPNG-like interface "kube proxy lib" from #2104 #3649

[WIP do not merge] Kube-Proxy Library: Breakout a KPNG-like interface "kube proxy lib" from #2104 #3649

jayunit100 commented Nov 8, 2022

k8s-ci-robot commented Nov 8, 2022

astoycos commented Nov 11, 2022

danwinship Nov 11, 2022

astoycos Dec 8, 2022

astoycos Dec 8, 2022

jayunit100 Dec 9, 2022

danwinship Nov 29, 2022

jayunit100 Dec 6, 2022

danwinship Nov 29, 2022

jayunit100 Dec 6, 2022

danwinship Nov 29, 2022

jayunit100 Dec 6, 2022

danwinship Nov 29, 2022

jayunit100 Dec 6, 2022

danwinship Dec 6, 2022

jayunit100 Dec 6, 2022

danwinship Nov 29, 2022

jayunit100 Dec 6, 2022

astoycos commented Dec 2, 2022

aojea commented Dec 8, 2022

jayunit100 commented Dec 8, 2022

astoycos commented Dec 8, 2022

jayunit100 commented Dec 9, 2022

astoycos commented Dec 9, 2022

astoycos commented Dec 9, 2022 •

edited

Loading

astoycos commented Jan 26, 2023

k8s-ci-robot commented Jan 26, 2023


		#### Story 2

		As a Kubernetes maintainer, I don't want to have to understand the internals of a networking backend in order to simulate or write core updates to the logic of the kube-proxy locally.


		###### Will enabling / using this feature result in introducing new API types?

		Yes. There will be an in-memory API that is supported by this library, that is incremented overr time

[WIP do not merge] Kube-Proxy Library: Breakout a KPNG-like interface "kube proxy lib" from #2104 #3649

[WIP do not merge] Kube-Proxy Library: Breakout a KPNG-like interface "kube proxy lib" from #2104 #3649

Conversation

jayunit100 commented Nov 8, 2022

k8s-ci-robot commented Nov 8, 2022

astoycos commented Nov 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astoycos commented Dec 2, 2022

aojea commented Dec 8, 2022

jayunit100 commented Dec 8, 2022

astoycos commented Dec 8, 2022

jayunit100 commented Dec 9, 2022

astoycos commented Dec 9, 2022

astoycos commented Dec 9, 2022 • edited Loading

astoycos commented Jan 26, 2023

k8s-ci-robot commented Jan 26, 2023

astoycos commented Dec 9, 2022 •

edited

Loading