Create a new entry in ConfigMap that allows the admin to configure ssl_session_cache with builtin

[rikatz]

Follow up on #7080

Related comment: #7080 (comment)

Create a new entry in ConfigMap that allows the admin to configure ssl_session_cache with builtin

THIS SHOULD BE DISABLED BY DEFAULT!!

This may be helpful for folks that still wants to use builtin cache, and trying also to find that nginx bug

Questions, please find us on #ingress-nginx-dev

/help
/good-first-issue

[k8s-ci-robot]

@rikatz:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Follow up on #7080

Create a new entry in ConfigMap that allows the admin to configure ssl_session_cache with builtin

This may be helpful for folks that still wants to use builtin cache, and trying also to find that nginx bug

Questions, please find us on #ingress-nginx-dev

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jodevsa]

/assign

[rikatz]

@jodevsa thanks for getting this one.

Feel free to reach me if you have any questions.

Good place to start looking: https://github.com/kubernetes/ingress-nginx/blob/main/internal/ingress/controller/config/config.go#L93

[jodevsa]

Thanks @rikatz happy to contribute :)

I'm wondering how to implement it without breaking or changing the existing SSLSessionCacheSize config

{{ if $cfg.SSLSessionCache }} ssl_session_cache shared:SSL:{{ $cfg.SSLSessionCacheSize }};

I can add a new config like SSLSesssionBuiltinSize, but then what is the expected state if both SSLSessionCacheSize and SSLSessionCacheSize is defined. Also SSLSessionCacheSize doesn't express that the type is shared:SSL

[jodevsa]

looks like we can have both

Both cache types can be used simultaneously, for example:

ssl_session_cache builtin:1000 shared:SSL:10m;

[jodevsa]

if we only need this to reproduce the case; One could set SSLSessionCacheSize to something like 10m builtin:1000.

[jodevsa]

I think this is also mentioned in #7777

One could still set builtin if needed via ssl-session-cache-size

[rikatz]

hum, if so then we can move forward yes :)

Anyway, thanks for your help on this @jodevsa
I will cut a release here and if we think this still needs to be added, feel free to keep on the contribution!

[iamNoah1]

/triage accepted
/priority important-longterm

[jodevsa]

@iamNoah1 is there any work still needed for this issue?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[kundan2707]

• ssl_session_cache
• ssl_session_cache_size

These options are present and can be configured by crreating a new entry in data selection of configmap.

https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#configuration-options

Is anything extra needs to be done for this ?

[kundan2707]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.