WIP: Scrape json metrics from nginx vts #325
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
@gianrubio we need two implementations, one for the default nginx status info and another for vts. This must be optional. We cannot force users to use the vts module and the default information does not contains all the information vts provides. |
gianrubio
changed the title
|
@aledbf got it! I'll do that |
|
Don't know if this is related, but we're using this as a sidecar container here: https://github.com/hnlq715/nginx-vts-exporter So my question is, wouldn't be simplier to create a example deployment POD, with ingress + the vts exporter? |
gianrubio
force-pushed
the
ngx-vts-prometheus
branch
from
224f748 to
23c2592
Compare
gianrubio
force-pushed
the
ngx-vts-prometheus
branch
from
23c2592 to
39b6909
Compare
| @@ -40,7 +42,10 @@ func (em exeMatcher) MatchAndName(nacl common.NameAndCmdline) (bool, string) { | |||
| } | |||
|
|
|||
| func (n *NGINXController) setupMonitor(args []string) { | |||
| pc, err := newProcessCollector(true, exeMatcher{"nginx", args}) | |||
| var enableVts = true | |||
There was a problem hiding this comment.
@aledbf when the nginxController starts the configmap are empty. Could I change the enable-vts-metrics from annotation to an argument?
There was a problem hiding this comment.
@gianrubio please no. Keep in mind we must support to switch the implementation if the enable-vts-metrics value is updated in the configmap.
There was a problem hiding this comment.
Ok, so what method is the recommend to call the setupMonitor? Is the reload method?
func (n NGINXController) Reload(data []byte) ([]byte, bool, error) {
There was a problem hiding this comment.
@gianrubio I think after this line is the most appropriate place.
gianrubio
force-pushed
the
ngx-vts-prometheus
branch
from
39b6909 to
8eced17
Compare
|
Coverage decreased (-1.3%) to 44.452% when pulling 8eced17aca208af5fab12e7dab3813a9c498f60d on gianrubio:ngx-vts-prometheus into 0aabfba on kubernetes:master. |
|
Coverage decreased (-1.4%) to 44.416% when pulling 645509e80102a5c295029e3d66cea033cca6f23a on gianrubio:ngx-vts-prometheus into 0aabfba on kubernetes:master. |
gianrubio
force-pushed
the
ngx-vts-prometheus
branch
from
645509e to
951cd26
Compare
gianrubio
force-pushed
the
ngx-vts-prometheus
branch
7 times, most recently
from
10b7de2 to
3fc59b9
Compare
upgrade vts to the latest version
gianrubio
force-pushed
the
ngx-vts-prometheus
branch
from
3fc59b9 to
6db5c9e
Compare
|
@aledbf could you review again? |
This PR add the ability to ingress scrape nginx-vts and convert json format to prometheus. I'm still working on this, it's one of my firsts golang codes so reviews are welcome.
Screenshot
TODO
Fixes #72, #305, #239