Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy cherrypick #7965

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Legacy cherrypick #7965

merged 3 commits into from
Nov 24, 2021

Conversation

strongjz
Copy link
Member

@strongjz strongjz commented Nov 24, 2021 •
edited
Loading

Cherry-pick to move default list definition to be an empty list

strongjz and others added 2 commits November 23, 2021 19:36
@strongjz
update default block list,docs, tests (kubernetes#7942)
a79f099 
* update default block list,docs, tests

* fix config for admin test

* gofmt

* remove the err return
@rikatz @strongjz
Change sanitization message from error to warning (kubernetes#7963)
eeb15d6 
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2021
@strongjz strongjz requested a review from rikatz November 24, 2021 00:39
@k8s-ci-robot k8s-ci-robot added area/docs approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2021
@rikatz
Copy link
Contributor

rikatz commented Nov 24, 2021

/lgtm
/hold
Until CI passes

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@strongjz
Copy link
Member Author

/kind feature
/triage accepted
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 24, 2021
@rikatz
Copy link
Contributor

rikatz commented Nov 24, 2021

/lgtm
Thanks!

@rikatz
Copy link
Contributor

rikatz commented Nov 24, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 18e6eb0 into kubernetes:legacy Nov 24, 2021
@strongjz strongjz deleted the legacy-cherrypick branch March 23, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikatz rikatz Awaiting requested review from rikatz

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strongjz @rikatz @k8s-ci-robot