-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static manifest generation uses kustomize instead of python #8099
Static manifest generation uses kustomize instead of python #8099
Conversation
@afirth: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold either this or #8000 should be merged but not both @rikatz this contains only the existing reordered manifests and the script changes. There are two comments in |
9500a3d
to
39159d6
Compare
/approve Also @afirth please rebase and let me know (as the lgtm will be removed) Thanks! |
39159d6
to
19c6855
Compare
@rikatz rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afirth, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
…es#8099) * regenerate at 4.0.12 * bash for loop and static values files * add .tool-versions * fixup static manifests with kustomize instead of python * remove spec.replicas where set * generate manifests for all supported versions * update docs * remove all versions except default (1.20) for now * update to 1.1.1/4.0.15
What this PR does / why we need it:
Currently, the static manifests are only compatible with K8s 1.20 APIs. This change generates static manifests for each supported version by calling
helm template
with the recently re-added--kube-version
flag. In this PR, only 1.20 is targeted. #8000 adds the other versions, however based on feedback that this was too big to review, I split the PR.Summary of changes
semverCompare
statements are respected e.g. this onehelm --namespace
is used to set the namespacehelm --kube-version
is used to set the target versiongenerate-deploy-scripts.sh
andadd-namespace.py
move to yaml files whose directory layout matches that of the generated manifestsTypes of changes
Which issue/s this PR fixes
building blocks to fix #7810
relates #8000
How Has This Been Tested?
See #8000 (comment) - Basically by calling
kustomize build > file
on both the existing and new manifests and confirming there is no diff (besides the AWS NLB example changing name + location to a subfolder)resulting diff - there isn't one
Checklist:
I have added tests to cover my changes.