-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioned static manifests #8162
Versioned static manifests #8162
Conversation
53793be
to
6a2a2ce
Compare
/kind feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/priority important-soon
I updated the description too but understand this could be daunting to a reviewer.
a reviewer could (untested) git checkout main
git checkout 6a2a2ce -- ./hack/generate-deploy-scripts.sh
./hack/generate-deploy-scripts.sh helm, and kustomize must be available (installable with asdf). RELEASE.md was also updated in #8099 with these instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afirth, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@longwuyuan docs were merged in #8099 https://github.com/kubernetes/ingress-nginx/blob/main/RELEASE.md#e-edit-the-static-manifests to update the python and ruyaml deps to helm+kustomize |
Just hoping to at least convert that word "kustomize" into a link to the customise software website. |
👍 go for it |
* update deploy script to generate static manifests for all supported versions * generate static manifests for all supported versions
Generate static manifests compatible with supported K8s versions, rather than just 1.20
What this PR does / why we need it:
Currently the helm templates have handling for different kubernetes versions, but the script to generate static manifests uses the helm default version (currently 1.20).
With this change the existing
deploy/static
manifests remain at 1.20 so we don't break docs, but additional folders are underneath with an explicit version.For more background see #8000 and #7810. #8099 is related.
Changes
The only real changes here are in hack/generate-deploy-scripts.sh
everything else is the result of running the script.
Types of changes
Which issue/s this PR fixes
/fixes #7810
How Has This Been Tested?
./generate-deploy-scripts.sh
1.19 does not have
appProtocol
oripFamilies
👍Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.(docs updates were completed in Static manifest generation uses kustomize instead of python #8099)