Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prow-build service account from group, grant permissions directly #1401

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Remove prow-build service account from group, grant permissions directly #1401

merged 1 commit into from
Nov 6, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Nov 6, 2020

Followup to #1393. Looks like I was wrong about service accounts picking up permission from group membership (ref: #1393 (comment))

Instead of granting all permissions that k8s-infra-staging-ci-images@ has, grant only write access to gcr.io/k8s-staging-ci-images

This replicates what I did manually

gsutil iam ch serviceAccount:prow-build@k8s-infra-prow-build.iam.gserviceaccount.com:roles/storage.objectAdmin gs://artifacts.k8s-staging-ci-images.appspot.com
gsutil iam ch serviceAccount:prow-build@k8s-infra-prow-build.iam.gserviceaccount.com:roles/storage.legacyBucketWriter gs://artifacts.k8s-staging-ci-images.appspot.com

@spiffxp
Remove prow-build service account from group, grant permissions directly
2a4a200 
Instead of granting all permissions that k8s-infra-staging-ci-images@
has, grant only write access to gcr.io/k8s-staging-ci-images
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra labels Nov 6, 2020
@spiffxp spiffxp mentioned this pull request Nov 6, 2020
Closed
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5299c37 into kubernetes:master Nov 6, 2020
@spiffxp spiffxp deleted the add-prow-build-svcacct-to-ci-images-gcr branch November 6, 2020 20:57
@ameukam ameukam mentioned this pull request Nov 6, 2020
Closed
@spiffxp spiffxp mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @justaugustus @k8s-ci-robot