Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci-kubernetes-build-canary error build. #19804

Closed

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Nov 2, 2020

Move the job to k8s-infra-prow-build-trusted cluster.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

Move the job to k8s-infra-prow-build-trusted cluster.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ameukam
To complete the pull request process, please assign saschagrunert after the PR has been reviewed.
You can assign the PR to them by writing /assign @saschagrunert in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2020
@k8s-ci-robot
Copy link
Contributor

@ameukam: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-test-infra-bazel d44f2b9 link /test pull-test-infra-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameukam apologies if I missed a conversation on this (I've been out of office for a few days), but do you have a linked issue or additional context on moving this to trusted cluster?

@ameukam
Copy link
Member Author

ameukam commented Nov 2, 2020

@hasheddan trying to fix kubernetes/kubernetes#95936.
Not sure if it's the right approach.

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I think it's entirely fine/expected for the k8s-infra-prow-build to have access to write images to the K8s Infra staging project (k8s-staging-ci-images).

I left a review on the other PR you opened on this --> kubernetes/k8s.io#1393 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020
@ameukam
Copy link
Member Author

ameukam commented Nov 6, 2020

Fix applied : kubernetes/k8s.io#1401.
/close

@k8s-ci-robot
Copy link
Contributor

@ameukam: Closed this PR.

In response to this:

Fix applied : kubernetes/k8s.io#1401.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam ameukam deleted the fix-ci-kubernetes-build-canary branch March 7, 2024 10:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants