Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove extra label from k8s-infra-prow" #2795

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Revert "Remove extra label from k8s-infra-prow" #2795

merged 1 commit into from
Sep 23, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 23, 2021 •
edited
Loading

Revert
dd1509e.

This prevent k8s-infra-ci-robot to merge PRs and conflict with
k8s-ci-robot.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ area/apps/prow k8s-infra-prow.k8s.io, code in apps/prow/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 23, 2021
@eddiezane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@eddiezane
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2021
eddiezane
eddiezane reviewed Sep 23, 2021
View reviewed changes
apps/prow/config.yaml
@@ -58,6 +58,7 @@ tide:
labels:
- lgtm
- approved
- a-label-that-does-not-exist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- a-label-that-does-not-exist
# This label allows k8s-infra-ci-robot to merge PRs and conflicts with k8s-ci-robot
- a-label-that-does-not-exist

@eddiezane
Copy link
Member

I'll add the comment in a separate PR. Sorry for breaking it.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2021
@ameukam
Revert "Remove extra label from k8s-infra-prow"
8571358 
Revert
kubernetes@dd1509e.

This prevents k8s-infra-ci-robot to merge PRs and conflicts with
k8s-ci-robot.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@eddiezane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@ameukam
Copy link
Member Author

ameukam commented Sep 23, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@ameukam: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ameukam ameukam reopened this Sep 23, 2021
@spiffxp
Copy link
Member

spiffxp commented Sep 23, 2021

/skip pull-k8s-infra-prow-config-validate

@spiffxp
Copy link
Member

spiffxp commented Sep 23, 2021

/override pull-k8s-infra-prow-config-validate

@spiffxp
Copy link
Member

spiffxp commented Sep 23, 2021

I'm not sure why I'm not able to override that status context... it's stuck in Pending.

Going to manually merge to get us back on track.

@spiffxp spiffxp merged commit 89f662a into kubernetes:main Sep 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 23, 2021
@eddiezane eddiezane mentioned this pull request Sep 23, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane eddiezane left review comments

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@eddiezane eddiezane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps/prow k8s-infra-prow.k8s.io, code in apps/prow/ area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @k8s-ci-robot @eddiezane @spiffxp