Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment for k8s-infra-prow tide labels #2800

Closed
wants to merge 1 commit into from
Closed

Add comment for k8s-infra-prow tide labels #2800

wants to merge 1 commit into from

Conversation

eddiezane
Copy link
Member

This PR is to ensure that #2795 does not happen.

/assign @ameukam

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2021
@k8s-ci-robot k8s-ci-robot added area/apps Application management, code in apps/ area/apps/prow k8s-infra-prow.k8s.io, code in apps/prow/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 23, 2021
@eddiezane
Add comment for k8s-infra-prow tide labels
52bb9c0 
Signed-off-by: Eddie Zaneski <eddiezane@gmail.com>
@ameukam
Copy link
Member

ameukam commented Sep 23, 2021

/hold
k8s-infra-ci-robot took over again.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2021
spiffxp
spiffxp approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
Sorry we didn't have something like this here in the first place. Good catch

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddiezane, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2021
@spiffxp
Copy link
Member

spiffxp commented Sep 23, 2021

k8s-infra-ci-robot took over again.

So the way to get its tide to stop trying to look at this repo is to remove the tide query entirely. The current status is that both tides report to the same context, so last one to update wins. It's not very friendly to new contributors to this repo. It does let us know that k8s-infra's tide is running and doing stuff though. So I could go either way.

ameukam added a commit to ameukam/k8s.io that referenced this pull request Sep 23, 2021
@ameukam
apps/prow: drop tide queries
828dd6d 
Suggestion of spiffxp:
kubernetes#2800 (comment).

Tide is not required for the moment.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam mentioned this pull request Sep 23, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

@eddiezane: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Sep 24, 2021

/close
I'm going to close this given #2803 merged

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closed this PR.

In response to this:

/close
I'm going to close this given #2803 merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eddiezane eddiezane deleted the ez/add-label-note branch September 24, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@spiffxp spiffxp

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps/prow k8s-infra-prow.k8s.io, code in apps/prow/ area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eddiezane @ameukam @k8s-ci-robot @spiffxp