Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/prow: drop tide queries #2803

Merged
merged 2 commits into from
Sep 24, 2021
Merged

apps/prow: drop tide queries #2803

merged 2 commits into from
Sep 24, 2021

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 23, 2021

Related to:

Suggestion of spiffxp:
#2800 (comment).

Tide is not required for the moment.

Also testing usage of KUBECONFIG as an attempt to address #2559.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@ameukam
apps/prow: drop tide queries
828dd6d 
Suggestion of spiffxp:
kubernetes#2800 (comment).

Tide is not required for the moment.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
apps/prow: Use KUBECONFIG env. variable
c2ef9ce 
Ref: kubernetes#2559
Part of kubernetes#1475

It's possible the kubeconfig is incorrectly parsed. Testing this theory.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2021
@ameukam
Copy link
Member Author

ameukam commented Sep 23, 2021

cc @spiffxp

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/apps Application management, code in apps/ area/apps/prow k8s-infra-prow.k8s.io, code in apps/prow/ labels Sep 23, 2021
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2021
spiffxp
spiffxp approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit abe7eb2 into kubernetes:main Sep 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 24, 2021
@spiffxp spiffxp mentioned this pull request Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@thockin thockin Awaiting requested review from thockin

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps/prow k8s-infra-prow.k8s.io, code in apps/prow/ area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ameukam @k8s-ci-robot @spiffxp