-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS: Redefine delegated administrators #4824
AWS: Redefine delegated administrators #4824
Conversation
Redefine the delegate administrators for some services. According the [AWS SRA](https://docs.aws.amazon.com/prescriptive-guidance/latest/security-reference-architecture/security-tooling.html), we should GuardDuty, CloudTrail, Config and Security Hub in the same account. Identity Center is the infra-shared services account. Storage lens S3 and Access Analyzer in the Audit account. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle AWS: Redefine delegated administrators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, makes sense.
/lgtm
resource "aws_organizations_delegated_administrator" "securityhub" { | ||
account_id = module.security_audit.account_id | ||
account_id = module.security_engineering.account_id | ||
service_principal = "securityhub.amazonaws.com" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we want to actually use this, it might be easiest to enable it via the AWS web console, once per region, and then have Security Hub take the responsibility for managing hubs within the organization.
We'd only need to access Security Engineering to do this, and the role we assume only need a few specific permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are enrolled in AWS Organizations, the organization management account can designate a Security Hub administrator account in each Region. securityhub-restrictons-recommendations
So if we want to set this through Terraform we'll have to create an AWS provider for each region and repeat "aws_organizations_delegated_administrator" " securityhub" resource for each provider. Correct?
I was looking at this other Terraform resource but I think it also has to be enabled for each region. aws_securityhub_organization_admin_account
Do we know which regions we want to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim Do you mind open an issue about Security Hub ?
Do we know which regions we want to use?
I would say all the regions enabled by default.
Ref: #4654 |
Redefine the delegate administrators for some services. According the AWS
SRA we should have: