Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Redefine delegated administrators #4824

Merged
merged 1 commit into from
Feb 22, 2023
Merged

AWS: Redefine delegated administrators #4824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 31 additions & 10 deletions infra/aws/terraform/management-account/delegated-admins.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,42 @@ limitations under the License.

# https://docs.aws.amazon.com/organizations/latest/userguide/orgs_integrate_services_list.html

resource "aws_organizations_delegated_administrator" "config_multiaccount" {
# Audit Account

resource "aws_organizations_delegated_administrator" "access_analyzer" {
account_id = module.security_audit.account_id
service_principal = "access-analyzer.amazonaws.com"
}

resource "aws_organizations_delegated_administrator" "storage_lens" {
account_id = module.security_audit.account_id
service_principal = "storage-lens.s3.amazonaws.com"
}

# Security Engineering Account

resource "aws_organizations_delegated_administrator" "config_multiaccount" {
account_id = module.security_engineering.account_id
service_principal = "config-multiaccountsetup.amazonaws.com"
}

resource "aws_organizations_delegated_administrator" "config" {
account_id = module.security_audit.account_id
account_id = module.security_engineering.account_id
service_principal = "config.amazonaws.com"
}

resource "aws_organizations_delegated_administrator" "guardduty" {
account_id = module.security_audit.account_id
service_principal = "guardduty.amazonaws.com"
resource "aws_organizations_delegated_administrator" "cloudtrail" {
account_id = module.security_engineering.account_id
service_principal = "cloudtrail.amazonaws.com"
}

resource "aws_organizations_delegated_administrator" "access_analyzer" {
account_id = module.security_audit.account_id
service_principal = "access-analyzer.amazonaws.com"
resource "aws_organizations_delegated_administrator" "guardduty" {
account_id = module.security_engineering.account_id
service_principal = "guardduty.amazonaws.com"
}

resource "aws_organizations_delegated_administrator" "securityhub" {
account_id = module.security_audit.account_id
account_id = module.security_engineering.account_id
service_principal = "securityhub.amazonaws.com"
}
Comment on lines 53 to 56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we want to actually use this, it might be easiest to enable it via the AWS web console, once per region, and then have Security Hub take the responsibility for managing hubs within the organization.

We'd only need to access Security Engineering to do this, and the role we assume only need a few specific permissions.

Copy link
Contributor

@deobieta deobieta Feb 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are enrolled in AWS Organizations, the organization management account can designate a Security Hub administrator account in each Region. securityhub-restrictons-recommendations

So if we want to set this through Terraform we'll have to create an AWS provider for each region and repeat "aws_organizations_delegated_administrator" " securityhub" resource for each provider. Correct?

I was looking at this other Terraform resource but I think it also has to be enabled for each region. aws_securityhub_organization_admin_account

Do we know which regions we want to use?

Copy link
Member Author

@ameukam ameukam Feb 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim Do you mind open an issue about Security Hub ?

Do we know which regions we want to use?

I would say all the regions enabled by default.


Expand All @@ -47,6 +61,13 @@ resource "aws_organizations_delegated_administrator" "fms" {
}

resource "aws_organizations_delegated_administrator" "detective" {
account_id = module.security_audit.account_id
account_id = module.security_engineering.account_id
service_principal = "detective.amazonaws.com"
}

# Infra-shared services

resource "aws_organizations_delegated_administrator" "identity_center" {
account_id = module.infra_shared_services.account_id
service_principal = "sso.amazonaws.com"
}