Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dl.k8s.io: Switch to Fastly #5603

Merged
merged 1 commit into from
Jul 24, 2023
Merged

dl.k8s.io: Switch to Fastly #5603

merged 1 commit into from
Jul 24, 2023

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jul 24, 2023

@ameukam
dl.k8s.io: Switch to Fastly
091be3c 
Related to:
  - kubernetes#4528

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2023
@ameukam
Copy link
Member Author

ameukam commented Jul 24, 2023

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/apps Application management, code in apps/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 24, 2023
@ameukam
Copy link
Member Author

ameukam commented Jul 24, 2023

/assign @dims @BenTheElder

@hakman
Copy link
Member

hakman commented Jul 24, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2023
@dims
Copy link
Member

dims commented Jul 24, 2023

/approve
/lgtm

/woof
/meow

@k8s-ci-robot
Copy link
Contributor

@dims: dog image

In response to this:

/approve
/lgtm

/woof
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@dims: cat image

In response to this:

/approve
/lgtm

/woof
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BenTheElder
BenTheElder reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member Author

ameukam commented Jul 24, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 89dba0a into kubernetes:main Jul 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 24, 2023
@BenTheElder BenTheElder mentioned this pull request Jul 24, 2023
Merged
@aojea
Copy link
Member

aojea commented Jul 24, 2023

This is great, is there any plan on how to measure the impact of this?

@BenTheElder
Copy link
Member

BenTheElder commented Jul 24, 2023 •
edited
Loading

We (=googlers) have observability on the bandwidth to the old GCS bucket and k8s infra leads have observability to the bandwidth through fastly and cache hit rate etc.

We're monitoring currently (myself + arnaud + fastly folks).

In the future other community members will have observability for the backing bucket when we replace it with a k8s infra owned release bucket, but first we'll get this working.

@BenTheElder BenTheElder mentioned this pull request Aug 23, 2023
Closed
@BenTheElder
Copy link
Member

#5726 for follow up data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@aojea aojea Awaiting requested review from aojea

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@dims dims

@BenTheElder BenTheElder

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
6 participants
@ameukam @hakman @dims @k8s-ci-robot @aojea @BenTheElder