Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dl.k8s.io tests #5614

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fix dl.k8s.io tests #5614

merged 1 commit into from
Jul 24, 2023

Conversation

BenTheElder
Copy link
Member

dl.k8s.io should point to cdn.dl.k8s.io now, not storage.googleapis.com

fixes postusbmit tests for #5603

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Jul 24, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and dims July 24, 2023 18:54
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2023
@BenTheElder
fix dl.k8s.io tests
613ff41 
dl.k8s.io should point to cdn.dl.k8s.io now, not storage.googleapis.com
@ameukam
Copy link
Member

ameukam commented Jul 24, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 029b002 into kubernetes:main Jul 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 24, 2023
@BenTheElder BenTheElder deleted the patch-dl-tests branch July 24, 2023 19:03
@BenTheElder BenTheElder mentioned this pull request Jul 24, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@dims dims Awaiting requested review from dims

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @ameukam