Add kompose.image-pull-secret

[mikesimos]

fixes #897

[hangyan]

I think it's not the best solution. Even though we support imagePullSecrets in kompose, there still need a Secret to exist first. If the user can simple add the secrets to the default serviceaccount, we don't need to support this at all.

[mikesimos]

Hi @hangyan. Can you point-out further info imagePullSecrets support in kompose? I couldn't find this feature supported somewhere in the code.
I think to further the expansion of kubernetes options support in kompose, will facilitate broader use of the tool ( see #897 ) . Bundling secrets close to the private image they are required for looks more intuitive and a cleaner solution to me.

[hangyan]

@cdrage

[cdrage]

@hangyan @mikesimos

I'm not opposed nor am I accepting of this. It's a tough decision.

In one case, we support imagePullSecrets but we dont support secrets.

The other case is the fact that this is a good intermediary step..

In my opinion, I believe we should delay this PR until #296 is completed. Kompose is meant to transition people whom are complete noobies to Kubernetes. Adding a label that supports image-pull-secrets but not explaining that you have to add secrets before hand isn't very Kompose-like.

@hangyan is right. The label can be completed instead by fully supporting secrets, rather than using an intermediary label. I'd suggest that we come back to this after #296 is completed and see if it's still applicable to merge.

[mikesimos]

OK! Having imagePullSecrets functionality upstream would be great. Thanks both!

[cdrage]

Hey @mikesimos does your PR here: #1040 override / close this one?

[mikesimos]

Closing as #1040 overrides this. Thanks!