Add kompose.image-pull-secret and kompose.image-pull-policy

[mikesimos]

No description provided.

[cdrage]

Tests are written, we've gotten multiple different PR's for this (#1039).

I think we should merge this in. At least until native secrets implementation is added.

What do you think @hangyan ?

[mikesimos]

@cdrage my bad. Looks like I 've included #1031 commits here as well.
Should I remove them from this PR, for distinct reviews, or just close #1031? Thanks!

[cdrage]

Coveralls

[cdrage]

Including them here is fine @mikesimos ! I think that we should merge in these labels as they've been requested quite a bit. At least until Secrets is natively implemented, the labels is a good middle-ground. As well as coverage for version 1/2 of Docker Compose.

Just waiting for reviews from @hangyan and maybe @xianlubird

[xianlubird]

@mikesimos

1. Maybe you should rebase these commits to one or two commits
2. How about compose v1 and v2
3. Until now, the PR is fine.

[mbana]

Awesome. Just what I was looking for.

Any ETA on when this might get merged into master?

[hangyan]

@mbana Secret can be added to the default ServiceAccount in the same namespace, check this out:
https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-imagepullsecrets-to-a-service-account After this ,you do not need to specify the secret name in the deployment or pod, kubernetes will figure it out itself

[mbana]

I should have been more clear. I am waiting for the kompose.image-pull-policy feature.

[hangyan]

@mikesimos Beside cdrage's comment, others LGTM

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[kiela]

@cdrage @hangyan Any chance to merge it and release as both of you said this feature can be shipped?

[cdrage]

When @mikesimos updates his PR / resolves conflicts I can take a look at the code and do a review. I don't see an issue anymore adding this 👍

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.