Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose annotations and labels on configmaps #1503

Closed
aecay opened this issue Jun 16, 2021 · 2 comments · Fixed by #1581
Closed

Expose annotations and labels on configmaps #1503

aecay opened this issue Jun 16, 2021 · 2 comments · Fixed by #1581
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@aecay
Copy link

aecay commented Jun 16, 2021

What would you like to be added:

Configmap metrics only export info, created, and resource_version (docs). It would be useful to see labels and annotations as well.

Why is this needed:

In my usecase, it's possible to use the labels/annotations applied to pods to track the rollout of versions of an application across different clusters (each with its own prometheus instance, aggregated in a single grafana dashboard -- the labels are applied by our deployment automation). Some of the "applications" have static (or rarely changing) code, and changes in behavior are instead driven by config map updates. It would be good to have a similar ability to track those rollouts via metrics, which requires exposing the labels and annotations to prometheus.

(In the above writeup I've referred to "labels and annotations". But perhaps it makes sense to prioritize one or the other -- that would probably work as well. Our tooling at the moment uses annotations but could probably be adjusted to use labels instead.)

Describe the solution you'd like

Exposure of kube_configmap_annotations and kube_configmap_labels -- exactly parallel to kube_namespace_annotations kube_pod_labels etc.

Additional context

@aecay aecay added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 16, 2021
@grzesuav
Copy link
Contributor

Hmm as far as I am aware in annotation there are some special fields (like lastAppliedConfiguration, generation etc) which should not be exposed (because of cardinality and sensitive information exposure)

@fpetkovski
Copy link
Contributor

There are two open PRs for exposing annotations for all resources, so it might be worth tracking those:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants