-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose configmap labels and annotations #1581
Expose configmap labels and annotations #1581
Conversation
f3fa88e
to
975780c
Compare
975780c
to
443c91a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit from my side otherwise looks good to me.
internal/store/builder.go
Outdated
@@ -238,119 +238,264 @@ func availableResources() []string { | |||
} | |||
|
|||
func (b *Builder) buildConfigMapStores() []*metricsstore.MetricsStore { | |||
return b.buildStoresFunc(configMapMetricFamilies, &v1.ConfigMap{}, createConfigMapListWatch, b.useAPIServerCache) | |||
return b.buildStoresFunc( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we should keep the same format as before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies. I had trouble fitting the line into the (24" 1080p) monitor - I use bigger fonts due to poor eyesight, Thought it may be an acceptable change.
I'll revert,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, it is just so that we keep the changes from this PR as small as possible. Also since these functions are very similar to one another, I think one-lining their body makes the overall file easier to read.
/lgtm |
/lgtm Thanks for the contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mindw, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds labels and annotations metrics to configmaps. Allowlist and tests are included.
How does this change affect the cardinality of KSM:
Not by default, Two new stable metrics added - with the same cardinally impact as other such metrics,
Which issue(s) this PR fixes:
Fixes #1503