-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation metrics #1495
Add annotation metrics #1495
Conversation
Welcome @sepich! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sepich The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c432593
to
cce1aee
Compare
cce1aee
to
6af1ccb
Compare
Hey, did you see there is #1468. Can you explain the diff between this one and that one, thanks! |
Sorry, i haven't seen #1468 as it not linked to the issue.
But only
(So, no
|
@sepich: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#1468 has been merged, so closing this one out. Feel free to reopen or create a new one if any changes are missing! |
What this PR does / why we need it:
This is continuation of #1041:
Provides a metric which exposes annotations for that particular API kind. By default it is disabled, but user could specify annotation keys to expose per-each API kind.
--metric-labels-allowlist/--metric-annotations-allowlist
provided for family - then label/annotation metrics would not be even exposed. Because it seems there is no sense in such metric alone:Sorry for large PR size, but this feature affects almost all families.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #941