Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in 2.7.0 with hpa metrics and Kubernetes 1.22 #1946

Closed
dankolt opened this issue Jan 7, 2023 · 8 comments
Closed

Breaking changes in 2.7.0 with hpa metrics and Kubernetes 1.22 #1946

dankolt opened this issue Jan 7, 2023 · 8 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@dankolt
Copy link

dankolt commented Jan 7, 2023

After merge #1906 hpa metrics can't collect from Kubernetes 1.22.
Kube-state-metrics logs tells that object *v2 HorizontalPodAutoscaler is undefined.
If it's expected behavior, then I guess need some note in release notes that minimal support k8s version is 1.23.

@dankolt dankolt added the kind/bug Categorizes issue or PR as related to a bug. label Jan 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 7, 2023
@razum2um
Copy link

razum2um commented Jan 9, 2023

Confirm this issue, k8s-1.22, prometheus-operator-kube-state-metrics-2.7.0 logs:

W0109 13:24:32.432243       1 reflector.go:424] pkg/mod/k8s.io/client-go@v0.25.4/tools/cache/reflector.go:169: failed to list *v2.HorizontalPodAutoscaler: the server could not find the requested resource
E0109 13:24:32.432271       1 reflector.go:140] pkg/mod/k8s.io/client-go@v0.25.4/tools/cache/reflector.go:169: Failed to watch *v2.HorizontalPodAutoscaler: failed to list *v2.HorizontalPodAutoscaler: the server could not find the requested resource

so for 1.22 the proper kube-state-metrics version is 2.6.0

p.s. and the maximum compatible chart of prometheus-operator is kube-prometheus-stack-42.0.3

@mrueg
Copy link
Member

mrueg commented Jan 9, 2023

I assume v2beta2 support got dropped and v2 got introduced in v1.23 (https://kubernetes.io/blog/2021/12/07/kubernetes-1-23-release-announcement/#horizontalpodautoscaler-v2-graduates-to-ga).

See: #1906

https://github.com/kubernetes/kube-state-metrics#compatibility-matrix

Since kubernetes 1.22 has already reached EOL upstream (https://kubernetes.io/releases/patch-releases/#non-active-branch-history), I would suggest to upgrade your clusters.

@razum2um
Copy link

razum2um commented Jan 9, 2023

Agree on upgrading, but worth mentioning a lot of people running in the cloud, in particular in aws/eks, where EOLs lagging behind by ~2 upstream versions, i.e. 1.22 is EOL in 3 months and released just 9 months ago

@mrueg
Copy link
Member

mrueg commented Jan 9, 2023

I can see your point, and you might want to talk to your public cloud provider to help out here.
If cloud vendors support EOL versions of Kubernetes for a longer time, they are more than welcome to contribute to the project.

@logicalhan
Copy link
Member

/triage accepted
/assign @mrueg

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 12, 2023
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 20, 2024
@dashpole
Copy link

dashpole commented Mar 7, 2024

1.22 is ancient at this point, so this probably isn't relevant anymore

/close

@k8s-ci-robot
Copy link
Contributor

@dashpole: Closing this issue.

In response to this:

1.22 is ancient at this point, so this probably isn't relevant anymore

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

7 participants