-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using autoscaling/v2 for HorizontalPodAutoscaler #1906
Conversation
Welcome @JoaoBraveCoding! |
Hello! 👋 There seems to be an assertion error due to the older package being in use: https://github.com/kubernetes/kube-state-metrics/actions/runs/3534506008/jobs/5932061461#step:5:369. |
Issue: kubernetes#1711 Problem: kube-state-metrics supports up to (latest k8s release - 3) k8s version. Since v1.25 has been release we can update it to start using autoscaler/v2. Solution: update packages to start using autoscaler/v2 Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
2f0b5ee
to
8f27e70
Compare
Yup! I forgot updating |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, JoaoBraveCoding The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Problem: kube-state-metrics supports up to (latest k8s release - 3) k8s version. Since v1.25 has been released we can update it to start using autoscaler/v2.
Solution: update packages to start using autoscaler/v2
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change cardinality
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1711
Related issue: https://issues.redhat.com/browse/OCPBUGS-3924