Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-3924: cherry-pick, autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+ #80

Merged

Conversation

JoaoBraveCoding
Copy link

Issue: https://issues.redhat.com/browse/OCPBUGS-3924

Problem: kube-state-metrics supports up to (latest k8s release - 3) k8s version. Since v1.25 has been release we can update it to start using autoscaler/v2.

Solution: update packages to start using autoscaler/v2

Issue: kubernetes#1711

Problem: kube-state-metrics supports up to (latest k8s release - 3) k8s
version. Since v1.25 has been release we can update it to start using
autoscaler/v2.

Solution: update packages to start using autoscaler/v2

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022
@JoaoBraveCoding JoaoBraveCoding changed the title OCPBUGS 3924: cherry-pick, autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+ OCPBUGS-3924: cherry-pick, autoscaling/v2beta2 HorizontalPodAutoscaler is deprecated in v1.23+ Nov 24, 2022
@openshift-ci-robot
Copy link

@JoaoBraveCoding: This pull request references Jira Issue OCPBUGS-3924, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-3924

Problem: kube-state-metrics supports up to (latest k8s release - 3) k8s version. Since v1.25 has been release we can update it to start using autoscaler/v2.

Solution: update packages to start using autoscaler/v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 24, 2022
@JoaoBraveCoding
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2022
@openshift-ci-robot
Copy link

@JoaoBraveCoding: This pull request references Jira Issue OCPBUGS-3924, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao November 24, 2022 12:19
@simonpasquier
Copy link

/lgtm

for reference this is the upstream PR: kubernetes#1906

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JoaoBraveCoding,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

@JoaoBraveCoding: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit abf4fa1 into openshift:master Nov 24, 2022
@openshift-ci-robot
Copy link

@JoaoBraveCoding: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3924 has been moved to the MODIFIED state.

In response to this:

Issue: https://issues.redhat.com/browse/OCPBUGS-3924

Problem: kube-state-metrics supports up to (latest k8s release - 3) k8s version. Since v1.25 has been release we can update it to start using autoscaler/v2.

Solution: update packages to start using autoscaler/v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JoaoBraveCoding: cannot checkout 4.12: error checking out 4.12: exit status 1. output: error: pathspec '4.12' did not match any file(s) known to git

In response to this:

/cherry-pick 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoaoBraveCoding
Copy link
Author

Wrong PR, too many on flight 🙈

@JoaoBraveCoding
Copy link
Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@JoaoBraveCoding: new pull request created: #83

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants