-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kube state metrics doesn't report init container pod metrics #502
Comments
There should be metrics on this, however, kube-state-metrics fundamentally only produces metrics for things that can be found in the API object, meaning as long as those don’t have that information we can’t create metrics for it. |
I understand. But what i can tell from source that kube-state-metrics doesn't read the init container status which is available in the API here. Right? I might be able to create a PR to include it if it makes sense. Thoughts? |
Yes that is correct, we'd be more than happy about a PR to add these! 🙂 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
What happened:
Can't see pod container metrics for init containers.
What you expected to happen:
Should see pod container metrics for init container like the "main" container
How to reproduce it (as minimally and precisely as possible):
deploy a pod with an init container and check for "kube_pod_container_status_terminated" metric. It doesn't contain init metrics.
Anything else we need to know?:
The code right now only looks at ContainerStatus which doesn't provide status for InitContainers
Environment:
The text was updated successfully, but these errors were encountered: