Add init container metrics #541

thedebugger · 2018-09-18T06:55:25Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #502

thedebugger · 2018-09-18T06:59:39Z

pkg/collectors/pod_test.go

+
+	type cs_to_prom func(cs v1.ContainerStatus, ns string, pod string) string
+
+	pod_to_prom := func(p v1.Pod, fn_cs cs_to_prom, fn_ics cs_to_prom) string {


in hindsight, refactoring this code in these methods may have made it more complex. But it makes changing things around a breeze and adding more pods/containers.

thedebugger · 2018-09-18T07:00:39Z

pkg/collectors/pod_test.go

+		return sb.String()
+	}
+
+	mk_cs := func(name string, id int, ready bool, rc int32) v1.ContainerStatus {


i might need to change the name of these methods. let me know

thedebugger · 2018-09-18T07:02:57Z

i'm going to test this in our cluster, but wanted to get it out to get feedback.

mxinden · 2018-09-18T11:59:24Z

pkg/collectors/pod_test.go

 		# HELP kube_pod_labels Kubernetes labels converted to Prometheus labels.
 		# TYPE kube_pod_labels gauge
 		# HELP kube_pod_container_status_ready Describes whether the containers readiness check succeeded.
 		# TYPE kube_pod_container_status_ready gauge
 		# HELP kube_pod_container_status_restarts_total The number of container restarts per container.
 		# TYPE kube_pod_container_status_restarts_total counter
+        # HELP kube_pod_init_container_status_restarts_total The number of init container restarts per container.


Can you fix the indentation?

mxinden · 2018-09-18T12:06:31Z

pkg/collectors/pod.go

@@ -382,21 +431,30 @@ func (pc *podCollector) collectPod(ch chan<- prometheus.Metric, p v1.Pod) {

 	var lastFinishTime float64

-	for _, cs := range p.Status.ContainerStatuses {
-		addGauge(descPodContainerInfo, 1,
+	collectContainerStatusMetric := func(cs v1.ContainerStatus, info *prometheus.Desc, waiting *prometheus.Desc, _waitingReason *prometheus.Desc, running *prometheus.Desc, terminated *prometheus.Desc, terminatedReason *prometheus.Desc, restarts *prometheus.Desc) {


How about instead of passing in each metric description as arguments to the function, just passing in a single boolean e.g. isInitContainer. The function then decides which metric descriptions to use based on that. Should make this less verbose.

I agree it would reduce the params but not sure if that make it less verbose.

if init { desc1 = init_metrics_desc1 ... } else { desc1 = metrics_desc1 ... } addGauge(metrics_desc1, 1)

If i can make the change if you strongly feel about it

What do others think?

how about a third way? we pass a map instead of each single description, that way we have a single parameter and we can initialize the map just like the descriptions

Sounds good. I made the change.

thedebugger · 2018-10-01T06:01:22Z

sorry, as I was rebasing it, the rebase changes got split across my commits. So I decided to squash them together for better readability. I'm going to test these changes in our cluster, but the PR is ready for final review. Let me know if you folks have more feedbacks.

fejta-bot · 2018-12-30T06:17:21Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2019-01-29T07:01:47Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2019-02-28T07:20:07Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2019-02-28T07:20:15Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

brancz · 2019-02-28T08:07:25Z

Sorry lost track of this.

/reopen

k8s-ci-robot · 2019-02-28T08:07:26Z

@brancz: Reopened this PR.

In response to this:

Sorry lost track of this.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-02-28T08:07:38Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thedebugger
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: brancz

If they are not already assigned, you can assign the PR to them by writing /assign @brancz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

brancz · 2019-02-28T10:42:23Z

Sorry for the delay. This needs a rebase.

tariq1890 · 2019-03-18T17:12:34Z

@thedebugger would you be able to update this PR?

thedebugger · 2019-04-09T02:54:48Z

@brancz @tariq1890 hey, i can try doing it but it is going to be a lot of work since the code has changed a lot. Could we have a smaller turn around time so that we can break this cycle? Let me know.

brancz · 2019-04-09T07:31:58Z

Usually turn around is very fast for this project, not sure why we dropped the ball here. Sorry!

fejta-bot · 2019-05-09T08:31:48Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2019-05-09T08:31:56Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 18, 2018

k8s-ci-robot requested review from andyxning and zouyee September 18, 2018 06:55

thedebugger commented Sep 18, 2018

View reviewed changes

thedebugger mentioned this pull request Sep 18, 2018

Added init containers pod metrics. #506

Closed

mxinden reviewed Sep 18, 2018

View reviewed changes

thedebugger force-pushed the init_container_metrics branch from fd9a67a to c9275b7 Compare October 1, 2018 05:56

Add init container metrics

cb096c5

thedebugger force-pushed the init_container_metrics branch from c9275b7 to cb096c5 Compare October 1, 2018 06:09

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2018

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 29, 2019

k8s-ci-robot closed this Feb 28, 2019

k8s-ci-robot reopened this Feb 28, 2019

k8s-ci-robot closed this May 9, 2019

tariq1890 mentioned this pull request May 17, 2019

Add pod init container metrics #762

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add init container metrics #541

Add init container metrics #541

thedebugger commented Sep 18, 2018

thedebugger Sep 18, 2018 •

edited

Loading

thedebugger Sep 18, 2018

thedebugger commented Sep 18, 2018

mxinden Sep 18, 2018

mxinden Sep 18, 2018

thedebugger Sep 20, 2018

mxinden Sep 24, 2018

brancz Sep 25, 2018

thedebugger Oct 1, 2018

thedebugger commented Oct 1, 2018

fejta-bot commented Dec 30, 2018

fejta-bot commented Jan 29, 2019

fejta-bot commented Feb 28, 2019

k8s-ci-robot commented Feb 28, 2019

brancz commented Feb 28, 2019

k8s-ci-robot commented Feb 28, 2019

k8s-ci-robot commented Feb 28, 2019

brancz commented Feb 28, 2019

tariq1890 commented Mar 18, 2019

thedebugger commented Apr 9, 2019

brancz commented Apr 9, 2019

fejta-bot commented May 9, 2019

k8s-ci-robot commented May 9, 2019


		type cs_to_prom func(cs v1.ContainerStatus, ns string, pod string) string

		pod_to_prom := func(p v1.Pod, fn_cs cs_to_prom, fn_ics cs_to_prom) string {

Add init container metrics #541

Add init container metrics #541

Conversation

thedebugger commented Sep 18, 2018

thedebugger Sep 18, 2018 • edited Loading

Choose a reason for hiding this comment

thedebugger Sep 18, 2018

Choose a reason for hiding this comment

thedebugger commented Sep 18, 2018

mxinden Sep 18, 2018

Choose a reason for hiding this comment

mxinden Sep 18, 2018

Choose a reason for hiding this comment

thedebugger Sep 20, 2018

Choose a reason for hiding this comment

mxinden Sep 24, 2018

Choose a reason for hiding this comment

brancz Sep 25, 2018

Choose a reason for hiding this comment

thedebugger Oct 1, 2018

Choose a reason for hiding this comment

thedebugger commented Oct 1, 2018

fejta-bot commented Dec 30, 2018

fejta-bot commented Jan 29, 2019

fejta-bot commented Feb 28, 2019

k8s-ci-robot commented Feb 28, 2019

brancz commented Feb 28, 2019

k8s-ci-robot commented Feb 28, 2019

k8s-ci-robot commented Feb 28, 2019

brancz commented Feb 28, 2019

tariq1890 commented Mar 18, 2019

thedebugger commented Apr 9, 2019

brancz commented Apr 9, 2019

fejta-bot commented May 9, 2019

k8s-ci-robot commented May 9, 2019

thedebugger Sep 18, 2018 •

edited

Loading