Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.0] Update go to 1.16, update dependencies, remove vendor directory #1419

Merged
merged 4 commits into from
Mar 18, 2021

Conversation

mrueg
Copy link
Member

@mrueg mrueg commented Mar 18, 2021

What this PR does / why we need it:
This changes the used go version in the build process to 1.16 and updates various dependencies.
It also removes the /vendor directory

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2021
k8s.io/apimachinery v0.18.3 => k8s.io/apimachinery v0.18.3
k8s.io/client-go v0.18.3 => k8s.io/client-go v0.20.0
k8s.io/api v0.18.3 => k8s.io/api v0.20.4
k8s.io/apimachinery v0.18.3 => k8s.io/apimachinery v0.20.4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilic not sure if you wanted to keep apimachinery on 0.18.3 on purpose or this change is okay

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely a mistake on my side, 0.20.4 sounds great!

mrueg and others added 2 commits March 18, 2021 14:18
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@mrueg mrueg changed the title [release-2.0] Update go to 1.16, update dependencies. [release-2.0] Update go to 1.16, update dependencies, remove vendor directory Mar 18, 2021
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you! Do you mind merging these changes into master as well?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6ba0712 into kubernetes:release-2.0 Mar 18, 2021
mrueg added a commit to mrueg/kube-state-metrics that referenced this pull request Mar 26, 2021
* [CHANGE] Rename --labels-metric-allow-list to --metric-labels-allowlist kubernetes#1424
* [CHANGE] Remove deprecated Kubernetes APIs kubernetes#1423
* [CHANGE] Remove vendor folder kubernetes#1419
@mrueg mrueg mentioned this pull request Mar 26, 2021
mrueg added a commit to mrueg/kube-state-metrics that referenced this pull request Mar 26, 2021
* [CHANGE] Rename --labels-metric-allow-list to --metric-labels-allowlist kubernetes#1424
* [CHANGE] Remove deprecated Kubernetes APIs kubernetes#1423
* [CHANGE] go.mod: Update Dependencies kubernetes#1419
* [CHANGE] Remove vendor folder kubernetes#1419
* [CHANGE] `k8s.gcr.io/kube-state-metrics/kube-state-metrics` becomes the authoritative registry
Location on quay.io will not be updated anymore. Previously pushed images will be kept around to avoid breaking existing deployments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants