-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut 2.0.0 rc.1 #1428
Cut 2.0.0 rc.1 #1428
Conversation
mrueg
commented
Mar 26, 2021
- [CHANGE] Rename --labels-metric-allow-list to --metric-labels-allowlist Rename cli flag from label-metrics-allow-list to metric-labels-allowlist #1424
- [CHANGE] Remove deprecated Kubernetes APIs Remove extensions APIs that are deprecated #1423
- [CHANGE] Remove vendor folder [release-2.0] Update go to 1.16, update dependencies, remove vendor directory #1419
/assign @lilic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
Couple of suggestions only.
* [CHANGE] Rename --labels-metric-allow-list to --metric-labels-allowlist #1424 | ||
* [CHANGE] Remove deprecated Kubernetes APIs #1423 | ||
* [CHANGE] Remove vendor folder #1419 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would include the 3ab8b19 as some of our users use kube-state-metrics as library, this should be helpful to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added a change log.
@@ -1,3 +1,9 @@ | |||
## v2.0.0-rc.1 / 2021-03-26 | |||
|
|||
* [CHANGE] Rename --labels-metric-allow-list to --metric-labels-allowlist #1424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also want to stop creating quay images, not sure if this is the right place to mention this or in the release itself, or both.
See #1409 for background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a note about quay.io and k8s.gcr.io
* [CHANGE] Rename --labels-metric-allow-list to --metric-labels-allowlist kubernetes#1424 * [CHANGE] Remove deprecated Kubernetes APIs kubernetes#1423 * [CHANGE] go.mod: Update Dependencies kubernetes#1419 * [CHANGE] Remove vendor folder kubernetes#1419 * [CHANGE] `k8s.gcr.io/kube-state-metrics/kube-state-metrics` becomes the authoritative registry Location on quay.io will not be updated anymore. Previously pushed images will be kept around to avoid breaking existing deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks! 🚀
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |