-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new promlint package and bump prometheus cli #1531
use new promlint package and bump prometheus cli #1531
Conversation
…rometheus/prometheus dependency Signed-off-by: Schlotter, Christian <christian.schlotter@daimler.com>
Signed-off-by: Schlotter, Christian <christian.schlotter@daimler.com>
Welcome @chrischdi! |
great stuff, lgtm |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chrischdi Thanks for your contribution! |
* [FEATURE] Add --use-apiserver-cache flag to set resourceVersion=0 for ListWatch requests kubernetes#1548 * [FEATURE] Introduce metrics for Kubernetes object annotations kubernetes#1468 * [FEATURE] Introduce start time metric for containers in terminated state kubernetes#1519 * [FEATURE] Introduce metrics for cronjob job history limits kubernetes#1535 * [FEATURE] Add system_uuid dimension to kube_node_info metric kubernetes#1535 * [FEATURE] Add available replica metric for statefulsets kubernetes#1532 * [FEATURE] Add ready replica metric for deployments kubernetes#1534 * [CHANGE] Update go clients for Kubernetes to support 1.22 kubernetes#1545 * [CHANGE] Use new promlint package and update prometheus cli to 2.28.1 kubernetes#1531
What this PR does / why we need it:
Update Prometheus CLI to 2.28.1
Make use of
github.com/prometheus/client_golang/prometheus/testutil/promlint
instead ofgit.luolix.top/prometheus/prometheus/util/promlint
and drop the dependencygit.luolix.top/prometheus/prometheus
.Dropping the dependency
Christian Schlotter , Daimler TSS GmbH, Imprintgit.luolix.top/prometheus/prometheus
helps to re-use kube-state-metric packages because the dependency lead to import it transitively by go modules.