-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arg use-api-server-cache to set resourceVersion=0 for ListWatch #1548
Add arg use-api-server-cache to set resourceVersion=0 for ListWatch #1548
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @liangyuanpeng! |
Had sign the CLA. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangyuanpeng, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Thanks for your contribution @liangyuanpeng ! |
* [FEATURE] Add --use-apiserver-cache flag to set resourceVersion=0 for ListWatch requests kubernetes#1548 * [FEATURE] Introduce metrics for Kubernetes object annotations kubernetes#1468 * [FEATURE] Introduce start time metric for containers in terminated state kubernetes#1519 * [FEATURE] Introduce metrics for cronjob job history limits kubernetes#1535 * [FEATURE] Add system_uuid dimension to kube_node_info metric kubernetes#1535 * [FEATURE] Add available replica metric for statefulsets kubernetes#1532 * [FEATURE] Add ready replica metric for deployments kubernetes#1534 * [CHANGE] Update go clients for Kubernetes to support 1.22 kubernetes#1545 * [CHANGE] Use new promlint package and update prometheus cli to 2.28.1 kubernetes#1531
Thanks so much for working on this @liangyuanpeng ! |
This cli arg was added in kubernetes/kube-state-metrics#1548 and is available since KSM v2.2.0. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
This cli arg was added in kubernetes/kube-state-metrics#1548 and is available since KSM v2.2.0. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
What this PR does / why we need it:
ref #1518
The ability to specify whether or not to use the k8s api server by setting the resourceVersion parameter (docs).
This would be immensely helpful for us as we run this application at quite a large scale (about 8mil total timeseries, 37k pods / cluster).
We constantly get these errors, which we presume is the cause for many of our metrics to not reflect reality (e.g. terminated pods that still exist as Running in metrics):
(not just with ConfigMaps but every resource type)
We don't need to be so strongly consistent, thus it would be nice to allow expose this option.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1518