-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hpa): status current metric #1725
feat(hpa): status current metric #1725
Conversation
Signed-off-by: Tanguy Falconnet <tfalconnet.externe@bedrockstreaming.com>
Welcome @tanguyfalconnet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far, just a few nits from my side
Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com>
Thanks for the contribution. Could you you also sign the CLA so that we can make the CI green? You can squash all your commits and run
|
CLA is being reviewed by my company. I'll sign it when everything is ready on our side. Next time it'll go faster ^^ |
@tanguyfalconnet do you have an update from your company on the CLA? |
@mrueg It's finally ok. It seems that similar code is already merged. I'll let you close it/merge it as you wish. |
Thanks for the update @tanguyfalconnet! |
/lgtm /hold |
Thank you for looking into this @tanguyfalconnet. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg, tanguyfalconnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Tanguy Falconnet tfalconnet.externe@bedrockstreaming.com
What this PR does / why we need it:
We want to be able to have current status of target metrics used by HPA.
We are currently not able to know if our HPA target metrics are healthy or in
<unknown>
state. Used in pair with prometheus-adapter for custom metric scaling, this is an important metric to check to monitor our clusters.How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Increases, as it adds a new metric
kube_horizontalpodautoscaler_status_current_target_metric
, mostly the same askube_horizontalpodautoscaler_spec_target_metric
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #